You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/06/19 20:01:21 UTC
[GitHub] jerrypeng commented on a change in pull request #1987: add
admin-api to update function with url
jerrypeng commented on a change in pull request #1987: add admin-api to update function with url
URL: https://github.com/apache/incubator-pulsar/pull/1987#discussion_r196558784
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
##########
@@ -130,9 +130,6 @@ public void close() {
runtime.stop();
runtime = null;
}
- if (runtimeFactory != null) {
Review comment:
Please see my comments for this on: #1988
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services