You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dan Norris <pr...@gmail.com> on 2015/08/06 05:54:21 UTC

Review Request 37157: Create Dockerfiles for building Aurora

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37157/
-----------------------------------------------------------

Review request for Aurora, Jake Farrell and Bill Farner.


Bugs: AURORA-1411
    https://issues.apache.org/jira/browse/AURORA-1411


Repository: aurora


Description
-------

Create Dockerfiles for building Aurora

I'm putting this up for preliminary review since there are a few things missing, namely:

- Docs
- Vagrant integration


Diffs
-----

  examples/docker/aurora-build/Dockerfile PRE-CREATION 
  examples/docker/aurora-build/aurora_docker_build.sh PRE-CREATION 
  examples/docker/aurora-run/Dockerfile PRE-CREATION 
  examples/docker/aurora-run/link_apps PRE-CREATION 
  examples/docker/aurora-run/supervisord.conf PRE-CREATION 

Diff: https://reviews.apache.org/r/37157/diff/


Testing
-------

docker build -t aurora/aurora-build examples/docker/aurora-build
docker build -t aurora/aurora-run examples/docker/aurora-run
docker run --rm -v $(pwd):/aurora aurora/aurora-build
docker run --rm -p 8081:8081 -p 5050:5050 -p 5051:5051 -p 8083:8083 -v $(pwd):aurora aurora/run


Thanks,

Dan Norris

Re: Review Request 37157: Create Dockerfiles for building Aurora

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37157/#review94345
-----------------------------------------------------------

Ship it!


Master (8adc9bd) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 6, 2015, 3:54 a.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37157/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 3:54 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-1411
>     https://issues.apache.org/jira/browse/AURORA-1411
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Create Dockerfiles for building Aurora
> 
> I'm putting this up for preliminary review since there are a few things missing, namely:
> 
> - Docs
> - Vagrant integration
> 
> 
> Diffs
> -----
> 
>   examples/docker/aurora-build/Dockerfile PRE-CREATION 
>   examples/docker/aurora-build/aurora_docker_build.sh PRE-CREATION 
>   examples/docker/aurora-run/Dockerfile PRE-CREATION 
>   examples/docker/aurora-run/link_apps PRE-CREATION 
>   examples/docker/aurora-run/supervisord.conf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37157/diff/
> 
> 
> Testing
> -------
> 
> docker build -t aurora/aurora-build examples/docker/aurora-build
> docker build -t aurora/aurora-run examples/docker/aurora-run
> docker run --rm -v $(pwd):/aurora aurora/aurora-build
> docker run --rm -p 8081:8081 -p 5050:5050 -p 5051:5051 -p 8083:8083 -v $(pwd):aurora aurora/run
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 37157: Create Dockerfiles for building Aurora

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37157/#review94405
-----------------------------------------------------------

Ship it!


Master (8adc9bd) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Aug. 6, 2015, 1:56 p.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37157/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2015, 1:56 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Bugs: AURORA-1411
>     https://issues.apache.org/jira/browse/AURORA-1411
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Create Dockerfiles for building Aurora
> 
> I'm putting this up for preliminary review since there are a few things missing, namely:
> 
> - Docs
> - Vagrant integration
> 
> 
> Diffs
> -----
> 
>   examples/docker/aurora-build/Dockerfile PRE-CREATION 
>   examples/docker/aurora-build/aurora_docker_build.sh PRE-CREATION 
>   examples/docker/aurora-run/Dockerfile PRE-CREATION 
>   examples/docker/aurora-run/link_apps PRE-CREATION 
>   examples/docker/aurora-run/supervisord.conf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37157/diff/
> 
> 
> Testing
> -------
> 
> docker build -t aurora/aurora-build examples/docker/aurora-build
> docker build -t aurora/aurora-run examples/docker/aurora-run
> docker run --rm -v $(pwd):/aurora aurora/aurora-build
> docker run --rm -p 8081:8081 -p 5050:5050 -p 5051:5051 -p 8083:8083 -v $(pwd):aurora aurora/run
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Re: Review Request 37157: Create Dockerfiles for building Aurora

Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37157/
-----------------------------------------------------------

(Updated Aug. 6, 2015, 1:56 p.m.)


Review request for Aurora, Jake Farrell and Bill Farner.


Bugs: AURORA-1411
    https://issues.apache.org/jira/browse/AURORA-1411


Repository: aurora


Description
-------

Create Dockerfiles for building Aurora

I'm putting this up for preliminary review since there are a few things missing, namely:

- Docs
- Vagrant integration


Diffs (updated)
-----

  examples/docker/aurora-build/Dockerfile PRE-CREATION 
  examples/docker/aurora-build/aurora_docker_build.sh PRE-CREATION 
  examples/docker/aurora-run/Dockerfile PRE-CREATION 
  examples/docker/aurora-run/link_apps PRE-CREATION 
  examples/docker/aurora-run/supervisord.conf PRE-CREATION 

Diff: https://reviews.apache.org/r/37157/diff/


Testing
-------

docker build -t aurora/aurora-build examples/docker/aurora-build
docker build -t aurora/aurora-run examples/docker/aurora-run
docker run --rm -v $(pwd):/aurora aurora/aurora-build
docker run --rm -p 8081:8081 -p 5050:5050 -p 5051:5051 -p 8083:8083 -v $(pwd):aurora aurora/run


Thanks,

Dan Norris

Re: Review Request 37157: Create Dockerfiles for building Aurora

Posted by Dan Norris <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37157/
-----------------------------------------------------------

(Updated Aug. 6, 2015, 1:54 p.m.)


Review request for Aurora, Jake Farrell and Bill Farner.


Changes
-------

Added maintainer lines


Bugs: AURORA-1411
    https://issues.apache.org/jira/browse/AURORA-1411


Repository: aurora


Description
-------

Create Dockerfiles for building Aurora

I'm putting this up for preliminary review since there are a few things missing, namely:

- Docs
- Vagrant integration


Diffs (updated)
-----

  examples/docker/aurora-build/Dockerfile PRE-CREATION 
  examples/docker/aurora-build/aurora_docker_build.sh PRE-CREATION 
  examples/docker/aurora-run/Dockerfile PRE-CREATION 
  examples/docker/aurora-run/link_apps PRE-CREATION 
  examples/docker/aurora-run/supervisord.conf PRE-CREATION 

Diff: https://reviews.apache.org/r/37157/diff/


Testing
-------

docker build -t aurora/aurora-build examples/docker/aurora-build
docker build -t aurora/aurora-run examples/docker/aurora-run
docker run --rm -v $(pwd):/aurora aurora/aurora-build
docker run --rm -p 8081:8081 -p 5050:5050 -p 5051:5051 -p 8083:8083 -v $(pwd):aurora aurora/run


Thanks,

Dan Norris