[GitHub] [incubator-superset] villebro commented on a change in pull request #9360: Migrate unique Heatmap controls

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9360: Migrate unique Heatmap controls
URL: https://github.com/apache/incubator-superset/pull/9360#discussion_r397003410
 
 

 ##########
 File path: superset-frontend/src/explore/controlPanels/Heatmap.js
 ##########
 @@ -18,6 +18,14 @@
  */
 import { t } from '@superset-ui/translation';
 import { nonEmpty } from '../validators';
+import { formatSelectOptionsForRange } from '../../modules/utils';
+
+const sortAxisChoices = [
+  ['alpha_asc', t('Axis ascending')],
+  ['alpha_desc', t('Axis descending')],
+  ['value_asc', t('Metric ascending')],
+  ['value_desc', t('Metric descending')],
+];
 
 Review comment:
   Note the added i18n and `sum(value)` -> `Metric`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org