You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/02 08:30:36 UTC

[GitHub] [spark] MaxGekk opened a new pull request, #36428: [SPARK-39087][SQL] Improve messages of error classes

MaxGekk opened a new pull request, #36428:
URL: https://github.com/apache/spark/pull/36428

   ### What changes were proposed in this pull request?
   In the PR, I propose to modify error messages of the following error classes: 
   - INVALID_JSON_SCHEMA_MAP_TYPE
   - INCOMPARABLE_PIVOT_COLUMN
   - INVALID_ARRAY_INDEX_IN_ELEMENT_AT
   - INVALID_ARRAY_INDEX
   - DIVIDE_BY_ZERO
   
   ### Why are the changes needed?
   To improve readability of error messages.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. It changes user-facing error messages.
   
   ### How was this patch tested?
   By running the modified test suites:
   ```
   $ build/sbt "sql/testOnly *QueryCompilationErrorsSuite*"
   $ build/sbt "sql/testOnly *QueryExecutionErrorsSuite*"
   $ build/sbt "sql/testOnly *QueryExecutionAnsiErrorsSuite"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #36428: [SPARK-39087][SQL] Improve messages of error classes

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #36428:
URL: https://github.com/apache/spark/pull/36428#issuecomment-1114974312

   It seems there are relevant UTs need to be fixed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #36428: [SPARK-39087][SQL] Improve messages of error classes

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36428:
URL: https://github.com/apache/spark/pull/36428#issuecomment-1115747192

   Merging to master. Thank you, @HyukjinKwon for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #36428: [SPARK-39087][SQL] Improve messages of error classes

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36428: [SPARK-39087][SQL] Improve messages of error classes
URL: https://github.com/apache/spark/pull/36428


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #36428: [SPARK-39087][SQL] Improve messages of error classes

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36428:
URL: https://github.com/apache/spark/pull/36428#issuecomment-1115180520

   @cloud-fan @HyukjinKwon @gengliangwang @srielau Could you review this PR, please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org