[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #330: [FLINK-29736] Abstract a table interface for both data and metadata tables

[GitBox <gi...@apache.org>]

LadyForest commented on code in PR #330:
URL: https://github.com/apache/flink-table-store/pull/330#discussion_r1004061771


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/Catalog.java:
##########
@@ -116,7 +117,7 @@ void dropDatabase(String name, boolean ignoreIfNotExists, boolean cascade)
      * @return The requested table
      * @throws TableNotExistException if the target does not exist
      */
-    default FileStoreTable getTable(ObjectPath tablePath) throws TableNotExistException {
+    default Table getTable(ObjectPath tablePath) throws TableNotExistException {

Review Comment:
   Better to update the method description at L#114
   ```
       Return a {@link Table} identified by ...
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org