You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/16 17:43:00 UTC

[GitHub] [netbeans] matthiasblaesing commented on pull request #1485: JEDDICT-322 org.netbeans.modules.db.core convert friend to public packages

matthiasblaesing commented on pull request #1485:
URL: https://github.com/apache/netbeans/pull/1485#issuecomment-710295850


   @lkishalmi why was this rushed in? There are open comments and @jGauravGupta asked what to do about that. Given that nobody really ensured db api is sane I'm already icky, that this is solved without a fried dependency, at least the changes I commented should have been done.
   
   And yes - I should have marked this as changes requested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists