You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Renjith Kamath <re...@gmail.com> on 2016/03/02 17:54:20 UTC
Review Request 44272: Install & Manage Zeppelin with Ambari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
Bugs: AMBARI-15265
https://issues.apache.org/jira/browse/AMBARI-15265
Repository: ambari
Description
-------
- add service defnition for Apache Zeppelin
- add support for Zeppelin view in Ambari
- add alert config
Diffs
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-ambari-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
contrib/views/pom.xml 627552a
contrib/views/zeppelin/pom.xml PRE-CREATION
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/44272/diff/
Testing
-------
- manual testing in vm
Thanks,
Renjith Kamath
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml, line 24
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283236#file1283236line24>
> >
> > version should be 0.6.0.2.5
>
> Renjith Kamath wrote:
> the service isn't listed properly in Add Service Wizard if the the folder name and the <version> are different.
OK, thats probably an Ambari infra bug. For now, lets modify the version and folder to 0.6.0.2.5 to be in line with other service definitions.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122478
-----------------------------------------------------------
On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py, line 1
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283230#file1283230line1>
> >
> > Remove this alert and add a WEB alert against zepplin listen port 9995
will update it in the follow-up patch
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, line 61
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line61>
> >
> > This is being executed as root. So the file created cannot be written by later commands. E.g. error:
> >
> > Execution of '/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh /usr/hdp/current/zeppelin-server/lib c6402.ambari.apache.org 9083 10001 c6402.ambari.apache.org 9995 True /var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package /usr/jdk64/jdk1.8.0_40 >> /var/log/zeppelin/zeppelin-setup.log' returned 1. -bash: /var/log/zeppelin/zeppelin-setup.log: Permission denied
fixed
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py, line 64
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283232#file1283232line64>
> >
> > Do we really need the public host? The code using this parameter is executed on the same host that runs Zeppelin.
removed
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py, line 56
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283232#file1283232line56>
> >
> > Not being used - can be deleted.
removed
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml, line 145
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283227#file1283227line145>
> >
> > Can be removed - not being used.
removed
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122478
-----------------------------------------------------------
On March 8, 2016, 7:18 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On March 8, 2016, 6:39 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml, line 24
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283236#file1283236line24>
> >
> > version should be 0.6.0.2.5
the service isn't listed properly in Add Service Wizard if the the folder name and the <version> are different.
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122478
-----------------------------------------------------------
On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122478
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml (line 145)
<https://reviews.apache.org/r/44272/#comment184490>
Can be removed - not being used.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml (line 173)
<https://reviews.apache.org/r/44272/#comment184488>
Does not seem right. Agent reports public and internal host names and that should be used instead of asking users to enter the public host name.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line 87)
<https://reviews.apache.org/r/44272/#comment184480>
For me on a plain vagrant VM install fails unless I edit epel.repo file to change baseurl from https to http
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py (line 1)
<https://reviews.apache.org/r/44272/#comment184484>
Remove this alert and add a WEB alert against zepplin listen port 9995
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 61)
<https://reviews.apache.org/r/44272/#comment184483>
This is being executed as root. So the file created cannot be written by later commands. E.g. error:
Execution of '/var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh /usr/hdp/current/zeppelin-server/lib c6402.ambari.apache.org 9083 10001 c6402.ambari.apache.org 9995 True /var/lib/ambari-agent/cache/common-services/ZEPPELIN/0.6.0.2.5.0.0/package /usr/jdk64/jdk1.8.0_40 >> /var/log/zeppelin/zeppelin-setup.log' returned 1. -bash: /var/log/zeppelin/zeppelin-setup.log: Permission denied
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py (line 56)
<https://reviews.apache.org/r/44272/#comment184489>
Not being used - can be deleted.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py (line 64)
<https://reviews.apache.org/r/44272/#comment184487>
Do we really need the public host? The code using this parameter is executed on the same host that runs Zeppelin.
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 24)
<https://reviews.apache.org/r/44272/#comment184476>
version should be 0.6.0.2.5
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 25)
<https://reviews.apache.org/r/44272/#comment184477>
folder should be 0.6.0. common-services is a common definition of service that should not be associated with specific HDP versions
- Sumit Mohanty
On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On March 9, 2016, 12:46 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml, line 84
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283229#file1283229line84>
> >
> > Lets remove epel-release.
removed in Rev 3
> On March 9, 2016, 12:46 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml, line 102
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283229#file1283229line102>
> >
> > Should this be zeppelin-env? zeppelin-ambari-config is no longer a config type
removed in Rev 4
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122642
-----------------------------------------------------------
On March 9, 2016, 5:21 a.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 5:21 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122642
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line 84)
<https://reviews.apache.org/r/44272/#comment184751>
Lets remove epel-release.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line 102)
<https://reviews.apache.org/r/44272/#comment184749>
Should this be zeppelin-env? zeppelin-ambari-config is no longer a config type
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py (line 1)
<https://reviews.apache.org/r/44272/#comment184750>
Thanks.
- Sumit Mohanty
On March 8, 2016, 7:18 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Rohit Choudhary <rc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122954
-----------------------------------------------------------
Ship it!
Review the view code.
- Rohit Choudhary
On March 9, 2016, 6:51 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 6:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 6509277
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122880
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On March 9, 2016, 6:51 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 9, 2016, 6:51 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 6509277
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/
-----------------------------------------------------------
(Updated March 9, 2016, 6:51 p.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
Changes
-------
add version for zeppelin
Bugs: AMBARI-15265
https://issues.apache.org/jira/browse/AMBARI-15265
Repository: ambari
Description
-------
- add service defnition for Apache Zeppelin
- add support for Zeppelin view in Ambari
- add alert config
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
contrib/views/pom.xml 6509277
contrib/views/zeppelin/pom.xml PRE-CREATION
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/44272/diff/
Testing
-------
- manual testing in vm
Thanks,
Renjith Kamath
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/
-----------------------------------------------------------
(Updated March 9, 2016, 10:04 a.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
Changes
-------
remove unused packages from osSpecifics in metainfo
Bugs: AMBARI-15265
https://issues.apache.org/jira/browse/AMBARI-15265
Repository: ambari
Description
-------
- add service defnition for Apache Zeppelin
- add support for Zeppelin view in Ambari
- add alert config
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
contrib/views/pom.xml 627552a
contrib/views/zeppelin/pom.xml PRE-CREATION
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/44272/diff/
Testing
-------
- manual testing in vm
Thanks,
Renjith Kamath
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/
-----------------------------------------------------------
(Updated March 9, 2016, 5:21 a.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
Bugs: AMBARI-15265
https://issues.apache.org/jira/browse/AMBARI-15265
Repository: ambari
Description
-------
- add service defnition for Apache Zeppelin
- add support for Zeppelin view in Ambari
- add alert config
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
contrib/views/pom.xml 627552a
contrib/views/zeppelin/pom.xml PRE-CREATION
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/44272/diff/
Testing
-------
- manual testing in vm
Thanks,
Renjith Kamath
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/
-----------------------------------------------------------
(Updated March 8, 2016, 7:18 p.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
Bugs: AMBARI-15265
https://issues.apache.org/jira/browse/AMBARI-15265
Repository: ambari
Description
-------
- add service defnition for Apache Zeppelin
- add support for Zeppelin view in Ambari
- add alert config
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
contrib/views/pom.xml 627552a
contrib/views/zeppelin/pom.xml PRE-CREATION
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/44272/diff/
Testing
-------
- manual testing in vm
Thanks,
Renjith Kamath
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml, line 63
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283229#file1283229line63>
> >
> > Zeppelin package should have the version in the name.
>
> Renjith Kamath wrote:
> Other pakages aren't using any version number for osSpecific/packages/package. e.g. Ambari Metrics
That is not correct. Ambari Metrics is not part of stack. All packages that are part of stack use versioned rpms. See ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122348
-----------------------------------------------------------
On March 8, 2016, 7:18 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, line 46
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line46>
> >
> > The rpm is responsible for creating the user.
not updated in rev3
> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, line 49
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line49>
> >
> > This is bound to fail in firewalled networks. Will need to figure out a way to include these in HDP UTILS and still be able to pip-install them.
> >
> > We cannot ship these packages with Ambari due to BSD license on numpy, scipy, pandas, scikit-learn, which has an advertisement clause.
removed `pip install` for additional python pacakges
> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py, line 70
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283232#file1283232line70>
> >
> > spark_version is not defined in case of an exception.
will fix it in the follow up patch
> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py, line 165
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283231#file1283231line165>
> >
> > Use a marker file on the file system to know if the first-time setup was successful.
earier we had a marker file to check for first-time setup, removed after a review comment
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122348
-----------------------------------------------------------
On March 8, 2016, 7:18 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 7:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
> On March 7, 2016, 7:37 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml, line 63
> > <https://reviews.apache.org/r/44272/diff/2/?file=1283229#file1283229line63>
> >
> > Zeppelin package should have the version in the name.
Other pakages aren't using any version number for osSpecific/packages/package. e.g. Ambari Metrics
- Renjith
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122348
-----------------------------------------------------------
On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122348
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml (line 47)
<https://reviews.apache.org/r/44272/#comment184307>
Typo here, "e.g.,"
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line 48)
<https://reviews.apache.org/r/44272/#comment184304>
All of these packages should go in HDP-UTILS instead
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml (line 63)
<https://reviews.apache.org/r/44272/#comment184314>
Zeppelin package should have the version in the name.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 34)
<https://reviews.apache.org/r/44272/#comment184308>
Why reload sys?
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 43)
<https://reviews.apache.org/r/44272/#comment184309>
Can we find this through another means that's deterministic?
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 46)
<https://reviews.apache.org/r/44272/#comment184310>
The rpm is responsible for creating the user.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 49)
<https://reviews.apache.org/r/44272/#comment184315>
This is bound to fail in firewalled networks. Will need to figure out a way to include these in HDP UTILS and still be able to pip-install them.
We cannot ship these packages with Ambari due to BSD license on numpy, scipy, pandas, scikit-learn, which has an advertisement clause.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 84)
<https://reviews.apache.org/r/44272/#comment184311>
This function name is misleading.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 145)
<https://reviews.apache.org/r/44272/#comment184317>
Eventally, this will need support for RU and EU. Ok with adding that in a follow-up patch.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py (line 165)
<https://reviews.apache.org/r/44272/#comment184312>
Use a marker file on the file system to know if the first-time setup was successful.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py (line 70)
<https://reviews.apache.org/r/44272/#comment184316>
spark_version is not defined in case of an exception.
- Alejandro Fernandez
On March 7, 2016, 7:09 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Renjith Kamath <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/
-----------------------------------------------------------
(Updated March 7, 2016, 7:09 p.m.)
Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
Changes
-------
review updates
Bugs: AMBARI-15265
https://issues.apache.org/jira/browse/AMBARI-15265
Repository: ambari
Description
-------
- add service defnition for Apache Zeppelin
- add support for Zeppelin view in Ambari
- add alert config
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-config.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/configuration/zeppelin-env.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/kerberos.json PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/master.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/setup_snapshot.sh PRE-CREATION
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/status_params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
contrib/views/pom.xml 627552a
contrib/views/zeppelin/pom.xml PRE-CREATION
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/44272/diff/
Testing
-------
- manual testing in vm
Thanks,
Renjith Kamath
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review121773
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py (line 4)
<https://reviews.apache.org/r/44272/#comment183602>
This alert is just checking for Zeppelin PID. This is not needed. status() command is enough. If Zepplin has a listen port then we need alerts that go against the port - see WEB or PORT type alerts in HBase and HDFS
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 145)
<https://reviews.apache.org/r/44272/#comment183603>
Delete this line.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 157)
<https://reviews.apache.org/r/44272/#comment183604>
Why OSX?
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 161)
<https://reviews.apache.org/r/44272/#comment183605>
How did these files reach /tmp folder?
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 165)
<https://reviews.apache.org/r/44272/#comment183606>
Need to use HdfsResource function call. We cannot rely on hdfs calls directly through Execute.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 171)
<https://reviews.apache.org/r/44272/#comment183607>
Remove all echo statements. If you need to log then use Logger.info(). Anyway, we should not need to read/print pid value.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 186)
<https://reviews.apache.org/r/44272/#comment183608>
Does the zeppelin pid file name change on every start? Could we create the name statically in status_params.py and then use it everywhere.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh (line 1)
<https://reviews.apache.org/r/44272/#comment183600>
When is this sh script used? Is it needed for Zeppelin start or install?
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh (line 68)
<https://reviews.apache.org/r/44272/#comment183601>
If Zeppelin needs hive-site then we should use the library in resource_management module to do it.
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 24)
<https://reviews.apache.org/r/44272/#comment183598>
It should be 0.6.0.2.5.0.0
ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml (line 26)
<https://reviews.apache.org/r/44272/#comment183599>
You need to add 2.5 specific package names such as zeppelin_2_5_* and zeppelin-2-5-.*.
See ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/metainfo.xml
- Sumit Mohanty
On March 2, 2016, 4:54 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 4:54 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-ambari-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review121692
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py (line 4)
<https://reviews.apache.org/r/44272/#comment183456>
Use explicit imports
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 28)
<https://reviews.apache.org/r/44272/#comment183457>
Use explicit imports
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 34)
<https://reviews.apache.org/r/44272/#comment183458>
Project uses indentation of 2 spaces.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 50)
<https://reviews.apache.org/r/44272/#comment183459>
We have a providers to install that will already use yum, apt-get, etc, based on the correct OS.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 58)
<https://reviews.apache.org/r/44272/#comment183460>
Can this use the exact version instead of /usr/hdp/current?
My concern is that during RU/EU it will need to install into a directoy that hasn't been made current yet.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py (line 24)
<https://reviews.apache.org/r/44272/#comment183461>
Use explicit imports
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py (line 30)
<https://reviews.apache.org/r/44272/#comment183462>
Simpler to just check for not None.
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py (line 64)
<https://reviews.apache.org/r/44272/#comment183464>
This should be surrounded with try-except or use "with open() as f"
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py (line 93)
<https://reviews.apache.org/r/44272/#comment183465>
Should check for length before getting element at [0]
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py (line 22)
<https://reviews.apache.org/r/44272/#comment183466>
Use explicit imports
- Alejandro Fernandez
On March 2, 2016, 4:54 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 4:54 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-ambari-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 44272: Install & Manage Zeppelin with Ambari
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review121940
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py (line 161)
<https://reviews.apache.org/r/44272/#comment183786>
For example I see these in /usr/hdp/2.5.0.0-56/zeppelin/lib/interpreter/spark/dep/zeppelin-spark-dependencies-0.6.0.2.5.0.0-56.jar. So if we need these in hdfs we can copy from this location.
- Sumit Mohanty
On March 2, 2016, 4:54 p.m., Renjith Kamath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> -----------------------------------------------------------
>
> (Updated March 2, 2016, 4:54 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
>
>
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-ambari-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-env.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/kerberos.json PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/alert_check_zeppelin.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/setup_snapshot.sh PRE-CREATION
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/status_params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml PRE-CREATION
> contrib/views/pom.xml 627552a
> contrib/views/zeppelin/pom.xml PRE-CREATION
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION
> contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION
> contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44272/diff/
>
>
> Testing
> -------
>
> - manual testing in vm
>
>
> Thanks,
>
> Renjith Kamath
>
>