You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/01/05 21:39:44 UTC
[jira] Created: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
remove (deprecate) unused NoSyncConnected from KeeperState
----------------------------------------------------------
Key: ZOOKEEPER-265
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
Project: Zookeeper
Issue Type: Improvement
Components: c client, java client, server
Affects Versions: 3.0.1, 3.0.0
Reporter: Patrick Hunt
Priority: Minor
Fix For: 3.1.0
deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-265:
-----------------------------------
Assignee: Patrick Hunt
Status: Patch Available (was: Open)
> remove (deprecate) unused NoSyncConnected from KeeperState
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Affects Versions: 3.0.1, 3.0.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-265.patch
>
>
> deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
> what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-265:
-----------------------------------
Attachment: ZOOKEEPER-265.patch
deprecated the unused states and also added javadoc.
> remove (deprecate) unused NoSyncConnected from KeeperState
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-265.patch
>
>
> deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
> what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663309#action_12663309 ]
Hudson commented on ZOOKEEPER-265:
----------------------------------
Integrated in ZooKeeper-trunk #194 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/194/])
. remove (deprecate) unused NoSyncConnected from KeeperState. (phunt via mahadev)
> remove (deprecate) unused NoSyncConnected from KeeperState
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-265.patch
>
>
> deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
> what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662121#action_12662121 ]
Mahadev konar commented on ZOOKEEPER-265:
-----------------------------------------
I just created ZOOKEEPER-270. Ill commit this patch.
> remove (deprecate) unused NoSyncConnected from KeeperState
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-265.patch
>
>
> deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
> what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662118#action_12662118 ]
Mahadev konar commented on ZOOKEEPER-265:
-----------------------------------------
+1 on the patch. We should open a new jira to reomve the deprecated constants in the next release.
> remove (deprecate) unused NoSyncConnected from KeeperState
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-265.patch
>
>
> deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
> what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-265) remove (deprecate) unused
NoSyncConnected from KeeperState
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-265:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Pat.
> remove (deprecate) unused NoSyncConnected from KeeperState
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-265
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client, java client, server
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-265.patch
>
>
> deprecate NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
> what about "Unknown"? that seems to be unused as well, deprecate it as well?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.