You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/24 03:10:00 UTC
Review Request 17295: Fixed slave to work correctly when executor resources
are not specified.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17295/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Ian Downes.
Bugs: MESOS-941
https://issues.apache.org/jira/browse/MESOS-941
Repository: mesos-git
Description
-------
See bug for details.
Diffs
-----
src/slave/cgroups_isolator.cpp 80155a3f0cd684a6aad9a37f61c5204d86032735
src/slave/slave.hpp b8acc1866353f4863aee5e2d3db4ac1f9d2a48a5
src/slave/slave.cpp aeecca0b8631c4b947d505a99d705f909d5986f7
Diff: https://reviews.apache.org/r/17295/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17295: Fixed slave to properly do memory isolation when
executor resources are not specified.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17295/#review32692
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 24, 2014, 2:14 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17295/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 2:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Ian Downes.
>
>
> Bugs: MESOS-941
> https://issues.apache.org/jira/browse/MESOS-941
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug for details.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 80155a3f0cd684a6aad9a37f61c5204d86032735
> src/slave/slave.hpp b8acc1866353f4863aee5e2d3db4ac1f9d2a48a5
> src/slave/slave.cpp aeecca0b8631c4b947d505a99d705f909d5986f7
>
> Diff: https://reviews.apache.org/r/17295/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17295: Fixed slave to properly do memory isolation when
executor resources are not specified.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17295/#review32696
-----------------------------------------------------------
Ship it!
Nice!
- Brenden Matthews
On Jan. 24, 2014, 2:14 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17295/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 2:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Ian Downes.
>
>
> Bugs: MESOS-941
> https://issues.apache.org/jira/browse/MESOS-941
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug for details.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 80155a3f0cd684a6aad9a37f61c5204d86032735
> src/slave/slave.hpp b8acc1866353f4863aee5e2d3db4ac1f9d2a48a5
> src/slave/slave.cpp aeecca0b8631c4b947d505a99d705f909d5986f7
>
> Diff: https://reviews.apache.org/r/17295/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17295: Fixed slave to properly do memory isolation when
executor resources are not specified.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17295/#review32694
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On Jan. 24, 2014, 2:14 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17295/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 2:14 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Ian Downes.
>
>
> Bugs: MESOS-941
> https://issues.apache.org/jira/browse/MESOS-941
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See bug for details.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.cpp 80155a3f0cd684a6aad9a37f61c5204d86032735
> src/slave/slave.hpp b8acc1866353f4863aee5e2d3db4ac1f9d2a48a5
> src/slave/slave.cpp aeecca0b8631c4b947d505a99d705f909d5986f7
>
> Diff: https://reviews.apache.org/r/17295/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 17295: Fixed slave to properly do memory isolation when
executor resources are not specified.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17295/
-----------------------------------------------------------
(Updated Jan. 24, 2014, 2:14 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and Ian Downes.
Changes
-------
updated the title.
Summary (updated)
-----------------
Fixed slave to properly do memory isolation when executor resources are not specified.
Bugs: MESOS-941
https://issues.apache.org/jira/browse/MESOS-941
Repository: mesos-git
Description
-------
See bug for details.
Diffs (updated)
-----
src/slave/cgroups_isolator.cpp 80155a3f0cd684a6aad9a37f61c5204d86032735
src/slave/slave.hpp b8acc1866353f4863aee5e2d3db4ac1f9d2a48a5
src/slave/slave.cpp aeecca0b8631c4b947d505a99d705f909d5986f7
Diff: https://reviews.apache.org/r/17295/diff/
Testing
-------
make check
Thanks,
Vinod Kone