[GitHub] drill pull request: Drill 4260: Adding support for "some" custom f...

[amansinha100 <gi...@git.apache.org>]

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/340#discussion_r52185980
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/FrameSupportTemplate.java ---
    @@ -134,44 +142,67 @@ private void cleanPartition() {
        * @throws DrillException if it can't write into the container
        */
       private int processPartition(final int currentRow) throws DrillException {
    -    logger.trace("process partition {}, currentRow: {}, outputCount: {}", partition, currentRow, outputCount);
    +    logger.trace("{} rows remaining to process, currentRow: {}, outputCount: {}", remainingRows, currentRow, outputCount);
     
         setupWriteFirstValue(internal, container);
     
    -    int row = currentRow;
    +    if (popConfig.isRows()) {
    +      return processROWS(currentRow);
    +    } else {
    +      return processRANGE(currentRow);
    +    }
    +  }
    +
    +  private int processROWS(int row) throws DrillException {
    +    //TODO we only need to call these once per batch
    --- End diff --
    
    Is this TODO still valid ?  Is the setup being done per partition rather than per batch ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---