You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/03/10 02:12:38 UTC

[GitHub] [servicecomb-java-chassis] codecov-io edited a comment on pull request #2288: [SCB-2187]Support reading yaml file config from config center

codecov-io edited a comment on pull request #2288:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2288#issuecomment-793407961


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=h1) Report
   > Merging [#2288](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=desc) (60c1c03) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/993e4750e136d585de5dc5378122298e348b20d7?el=desc) (993e475) will **decrease** coverage by `0.04%`.
   > The diff coverage is `21.62%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2288      +/-   ##
   ============================================
   - Coverage     80.17%   80.12%   -0.05%     
     Complexity     1369     1369              
   ============================================
     Files          1508     1508              
     Lines         40816    40852      +36     
     Branches       3477     3482       +5     
   ============================================
   + Hits          32724    32733       +9     
   - Misses         6598     6622      +24     
   - Partials       1494     1497       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...s/sources/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvYXJjaGFpdXMvc291cmNlcy9Db25maWdDZW50ZXJDb25maWd1cmF0aW9uU291cmNlSW1wbC5qYXZh) | `64.17% <0.00%> (-16.96%)` | `0.00 <0.00> (ø)` | |
   | [.../servicecomb/config/client/ConfigCenterConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvY2xpZW50L0NvbmZpZ0NlbnRlckNvbmZpZy5qYXZh) | `71.42% <25.00%> (-9.06%)` | `0.00 <0.00> (ø)` | |
   | [...n/java/org/apache/servicecomb/config/YAMLUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9ZQU1MVXRpbC5qYXZh) | `66.66% <38.46%> (-23.81%)` | `0.00 <0.00> (ø)` | |
   | [.../servicecomb/config/client/ConfigCenterClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvY2xpZW50L0NvbmZpZ0NlbnRlckNsaWVudC5qYXZh) | `52.10% <50.00%> (-0.02%)` | `0.00 <0.00> (ø)` | |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `90.00% <0.00%> (-3.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `70.48% <0.00%> (+0.38%)` | `0.00% <0.00%> (ø%)` | |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (+3.50%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=footer). Last update [993e475...60c1c03](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2288?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org