You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Jakob Homan <jg...@apache.org> on 2011/11/03 04:25:00 UTC
Review Request: GIRAPH-644
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/
-----------------------------------------------------------
Review request for giraph.
Summary
-------
create giraphrunner
Diffs
-----
/trunk/bin/giraph PRE-CREATION
/trunk/pom.xml 1196926
/trunk/src/main/assembly/assembly.xml PRE-CREATION
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION
/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926
Diff: https://reviews.apache.org/r/2700/diff
Testing
-------
Thanks,
Jakob
Re: Review Request: GIRAPH-64
Posted by Jakob Homan <jg...@apache.org>.
> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > It would be super cool if, like in Mahout and Hadoop, we could print out the set of Vertex impls / algorithms / actions available. In Mahout, we have a properties file which we keep updating. Even nicer (maybe?) would be to just search the classpath for all classes which implement BasicVertex, and list them. Even cooler: have a new abstract method on BasicVertex "String getHelp()" which GiraphRunner could run via reflection to get the help output for the task.
Absolutely. Another JIRA?
> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > /trunk/src/main/java/org/apache/giraph/GiraphRunner.java, lines 40-41
> > <https://reviews.apache.org/r/2700/diff/1/?file=55937#file55937line40>
> >
> > Do these both need to be set? -of is certainly not required by the framework.
Yeah, I'll remove it from required, although I want to open a new JIRA to remove this is a provided default. It seems a bit odd that our default is to pipe the results to /dev/null essentially. There are certainly calculations that might want to do that, but throwing away work shouldn't be the default.
> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > /trunk/src/main/java/org/apache/giraph/GiraphRunner.java, lines 96-97
> > <https://reviews.apache.org/r/2700/diff/1/?file=55937#file55937line96>
> >
> > ip vs i ?
Whoops.
> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > /trunk/src/main/java/org/apache/giraph/GiraphRunner.java, lines 50-51
> > <https://reviews.apache.org/r/2700/diff/1/?file=55937#file55937line50>
> >
> > both are required? below you only use them if they are supplied.
No, only the ones in the required array are required. The true here is for if they have arguments. Neither are required. There are only three that are required, workers, inputformat and uhh... uhh... I forget the third one.
> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > /trunk/src/main/java/org/apache/giraph/GiraphRunner.java, line 110
> > <https://reviews.apache.org/r/2700/diff/1/?file=55937#file55937line110>
> >
> > !isQuiet vs verbose... we're defaulting to "verbose" in this case?
yeah. Verbose shows the MR progress, which is the default for Pig and Hive. I'm not sure about Mahout.
- Jakob
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/#review3023
-----------------------------------------------------------
On 2011-11-03 03:25:11, Jakob Homan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2700/
> -----------------------------------------------------------
>
> (Updated 2011-11-03 03:25:11)
>
>
> Review request for giraph.
>
>
> Summary
> -------
>
> create giraphrunner
>
>
> Diffs
> -----
>
> /trunk/bin/giraph PRE-CREATION
> /trunk/pom.xml 1196926
> /trunk/src/main/assembly/assembly.xml PRE-CREATION
> /trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION
> /trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926
>
> Diff: https://reviews.apache.org/r/2700/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jakob
>
>
Re: Review Request: GIRAPH-64
Posted by Dmitriy Ryaboy <dv...@gmail.com>.
> On 2011-11-03 05:32:49, Jake Mannix wrote:
> > It would be super cool if, like in Mahout and Hadoop, we could print out the set of Vertex impls / algorithms / actions available. In Mahout, we have a properties file which we keep updating. Even nicer (maybe?) would be to just search the classpath for all classes which implement BasicVertex, and list them. Even cooler: have a new abstract method on BasicVertex "String getHelp()" which GiraphRunner could run via reflection to get the help output for the task.
>
> Jakob Homan wrote:
> Absolutely. Another JIRA?
abstract method or annotation?
Nice thing about annotations is that you can hook into them during compilation and produce docs...
- Dmitriy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/#review3023
-----------------------------------------------------------
On 2011-11-12 02:03:20, Jakob Homan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2700/
> -----------------------------------------------------------
>
> (Updated 2011-11-12 02:03:20)
>
>
> Review request for giraph.
>
>
> Summary
> -------
>
> create giraphrunner
>
>
> This addresses bug GIRAPH-64.
> https://issues.apache.org/jira/browse/GIRAPH-64
>
>
> Diffs
> -----
>
> /trunk/bin/giraph PRE-CREATION
> /trunk/pom.xml 1196926
> /trunk/src/main/assembly/assembly.xml PRE-CREATION
> /trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION
> /trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926
>
> Diff: https://reviews.apache.org/r/2700/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jakob
>
>
Re: Review Request: GIRAPH-64
Posted by Jake Mannix <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/#review3023
-----------------------------------------------------------
It would be super cool if, like in Mahout and Hadoop, we could print out the set of Vertex impls / algorithms / actions available. In Mahout, we have a properties file which we keep updating. Even nicer (maybe?) would be to just search the classpath for all classes which implement BasicVertex, and list them. Even cooler: have a new abstract method on BasicVertex "String getHelp()" which GiraphRunner could run via reflection to get the help output for the task.
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6742>
Do these both need to be set? -of is certainly not required by the framework.
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6743>
both are required? below you only use them if they are supplied.
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6744>
ip vs i ?
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java
<https://reviews.apache.org/r/2700/#comment6745>
!isQuiet vs verbose... we're defaulting to "verbose" in this case?
- Jake
On 2011-11-03 03:25:11, Jakob Homan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2700/
> -----------------------------------------------------------
>
> (Updated 2011-11-03 03:25:11)
>
>
> Review request for giraph.
>
>
> Summary
> -------
>
> create giraphrunner
>
>
> Diffs
> -----
>
> /trunk/bin/giraph PRE-CREATION
> /trunk/pom.xml 1196926
> /trunk/src/main/assembly/assembly.xml PRE-CREATION
> /trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION
> /trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926
>
> Diff: https://reviews.apache.org/r/2700/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jakob
>
>
Re: Review Request: GIRAPH-64
Posted by Jakob Homan <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/
-----------------------------------------------------------
(Updated 2011-11-12 02:03:20.188294)
Review request for giraph.
Summary
-------
create giraphrunner
This addresses bug GIRAPH-64.
https://issues.apache.org/jira/browse/GIRAPH-64
Diffs
-----
/trunk/bin/giraph PRE-CREATION
/trunk/pom.xml 1196926
/trunk/src/main/assembly/assembly.xml PRE-CREATION
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION
/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926
Diff: https://reviews.apache.org/r/2700/diff
Testing
-------
Thanks,
Jakob
Re: Review Request: GIRAPH-64
Posted by Jakob Homan <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2700/
-----------------------------------------------------------
(Updated 2011-11-03 03:25:11.909806)
Review request for giraph.
Summary (updated)
-------
create giraphrunner
Diffs
-----
/trunk/bin/giraph PRE-CREATION
/trunk/pom.xml 1196926
/trunk/src/main/assembly/assembly.xml PRE-CREATION
/trunk/src/main/java/org/apache/giraph/GiraphRunner.java PRE-CREATION
/trunk/src/main/java/org/apache/giraph/graph/GraphMapper.java 1196926
Diff: https://reviews.apache.org/r/2700/diff
Testing
-------
Thanks,
Jakob