You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/08 22:42:16 UTC
[GitHub] [couchdb] nickva opened a new pull request #2429: Remove EUnit
retries on failure
nickva opened a new pull request #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429
Since we switched from Travis to Jenkins, let's see how tests run without
retries in the new environment.
For reference, retries were introduced in: https://github.com/apache/couchdb/commit/220462a1dd2d921fc4ecba3488f5fedefb75217f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on issue #2429: Remove EUnit retries on
failure
Posted by GitBox <gi...@apache.org>.
nickva commented on issue #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429#issuecomment-572297356
Interesting, got one seemingly flaky failure on first run:
```
] chttpd_purge_tests:208: test_partial_purge_request...[0.049 s] ok
[2020-01-08T22:49:17.758Z] undefined
[2020-01-08T22:49:17.758Z] *** context setup failed ***
[2020-01-08T22:49:17.758Z] **in function chttpd_purge_tests:'-create_db/1-fun-0-'/1 (test/eunit/chttpd_purge_tests.erl, line 43)
[2020-01-08T22:49:17.758Z] in call from chttpd_purge_tests:setup/0 (test/eunit/chttpd_purge_tests.erl, line 32)
[2020-01-08T22:49:17.758Z] **error:{assert,[{module,chttpd_purge_tests},
[2020-01-08T22:49:17.758Z] {line,43},
[2020-01-08T22:49:17.758Z] {expression,"Status =:= 201 orelse Status =:= 202"},
[2020-01-08T22:49:17.758Z] {expected,true},
[2020-01-08T22:49:17.758Z] {value,false}]}
[2020-01-08T22:49:17.758Z]
```
Don't think I've seen that one before
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on issue #2429: Remove EUnit retries on
failure
Posted by GitBox <gi...@apache.org>.
nickva commented on issue #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429#issuecomment-572387260
@davisp I did a bit of investigating https://github.com/apache/couchdb/issues/2424#issuecomment-572304711. Log file shows that flakiness coming from the auth (user / pass) not working after the setup finishes. So first PUT ends up with a 401 instead of 201/202.
If nothing comes obvious is wrong, we could do something like `test_util:wait_until...` until auth is finally ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on issue #2429: Remove EUnit retries on
failure
Posted by GitBox <gi...@apache.org>.
nickva commented on issue #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429#issuecomment-572298880
@wohali Ah interesting. New environment and fun and excited new failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva edited a comment on issue #2429: Remove EUnit
retries on failure
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on issue #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429#issuecomment-572387260
@davisp I did a bit of investigating https://github.com/apache/couchdb/issues/2424#issuecomment-572304711. Log file shows that flakiness coming from the auth (user / pass) not working after the setup finishes. So first PUT ends up with a 401 instead of 201/202.
If there is not obvious error in the flakiness, we could do something like `test_util:wait_until...` until auth is finally ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] davisp commented on issue #2429: Remove EUnit retries on
failure
Posted by GitBox <gi...@apache.org>.
davisp commented on issue #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429#issuecomment-572313313
I've seen this one on a number of builds as well. I'll take it to be a flaky test and look tomorrow.
Part of removing the loop is to avoid letting it compensate for these flaky tests so we finally fix things so I can't say this is a bad thing necessarily.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] wohali commented on issue #2429: Remove EUnit retries on
failure
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429#issuecomment-572298290
@nickva I got this failure a couple of times last night, even without this change. See #2424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva merged pull request #2429: Remove EUnit retries on
failure
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #2429: Remove EUnit retries on failure
URL: https://github.com/apache/couchdb/pull/2429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services