You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Amar Kamat (JIRA)" <ji...@apache.org> on 2010/07/28 15:14:16 UTC
[jira] Created: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_FINISHED as event type for reduce tasks
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_FINISHED as event type for reduce tasks
----------------------------------------------------------------------------------------------------------------
Key: MAPREDUCE-1980
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Amar Kamat
Assignee: Amar Kamat
TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
/** Get the event type */
public EventType getEventType() {
return EventType.MAP_ATTEMPT_STARTED;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926122#action_12926122 ]
Hudson commented on MAPREDUCE-1980:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Fix For: 0.21.0
>
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898162#action_12898162 ]
Amar Kamat commented on MAPREDUCE-1980:
---------------------------------------
{{test-patch}} passed on my box. Few contrib tests failed but doesn't seem related to my patch. Looking into it.
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897427#action_12897427 ]
Hong Tang commented on MAPREDUCE-1980:
--------------------------------------
Patch looks good. +1.
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898092#action_12898092 ]
Amareshwari Sriramadasu commented on MAPREDUCE-1980:
----------------------------------------------------
Patch looks good.
Amar, Can you post the test results? Will check-in this into trunk and branch 0.21.
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated MAPREDUCE-1980:
----------------------------------
Summary: TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks (was: TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_FINISHED as event type for reduce tasks)
Description:
TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
/** Get the event type */
public EventType getEventType() {
return EventType.MAP_ATTEMPT_KILLED;
}
was:
TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
/** Get the event type */
public EventType getEventType() {
return EventType.MAP_ATTEMPT_STARTED;
}
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898551#action_12898551 ]
Amareshwari Sriramadasu commented on MAPREDUCE-1980:
----------------------------------------------------
bq. Few contrib tests failed but doesn't seem related to my patch. Looking into it
I just checked the failing tests. This is because of MAPREDUCE-1920. completed job store is disabled for mapred unit tests by adding it to src/test. but contrib tests would not pickup mapred-site.xml from src/test. So, the tests are failing.
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated MAPREDUCE-1980:
----------------------------------
Attachment: mapreduce-1980-v1.0.patch
Attaching a patch the fixes the bug. test-patch and ant-tests passed on my box.
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu resolved MAPREDUCE-1980.
------------------------------------------------
Hadoop Flags: [Reviewed]
Fix Version/s: 0.21.0
Resolution: Fixed
All the tests pass after MAPREDUCE-2012
I just committed this to trunk and branch 0.21
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Fix For: 0.21.0
>
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated MAPREDUCE-1980:
----------------------------------
Attachment: mapreduce-1980-v1.1.patch
Attaching a patch that incorporates Amareshwari's comments. Modified the testcase too.
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897567#action_12897567 ]
Amareshwari Sriramadasu commented on MAPREDUCE-1980:
----------------------------------------------------
The same problem is present in TaskAttemptFinishedEvent also. setup and cleanup tasks are always logged as MAP_ATTEMPT_FINISHED. Can you fix that also?
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Attachments: mapreduce-1980-v1.0.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1980)
TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs
MAP_ATTEMPT_KILLED as event type for reduce tasks
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898804#action_12898804 ]
Amareshwari Sriramadasu commented on MAPREDUCE-1980:
----------------------------------------------------
Thanks Amar!
> TaskAttemptUnsuccessfulCompletionEvent.java incorrectly logs MAP_ATTEMPT_KILLED as event type for reduce tasks
> --------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1980
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1980
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Fix For: 0.21.0
>
> Attachments: mapreduce-1980-v1.0.patch, mapreduce-1980-v1.1.patch
>
>
> TaskAttemptUnsuccessfulCompletionEvent is used to log unsuccessful map and reduce task attempts to JobHistory. Following is the implementation of getEventType() method of TaskAttemptUnsuccessfulCompletionEvent
> /** Get the event type */
> public EventType getEventType() {
> return EventType.MAP_ATTEMPT_KILLED;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.