You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Vishanth <gi...@git.apache.org> on 2015/04/27 11:41:22 UTC

[GitHub] stratos pull request: Adding properties to add payload parameters ...

GitHub user Vishanth opened a pull request:

    https://github.com/apache/stratos/pull/289

    Adding properties to add payload parameters in network partition

    Adding payload parameters to network partitions. This functionality will be needed for passing network partition specific parameters to instances. Example: Puppet Master information per network partition.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Vishanth/stratos payload

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #289
    
----
commit 12a7e5825cf0e93e518915714654dd01e329b33f
Author: Vishanth <vi...@gmail.com>
Date:   2015-04-27T08:00:28Z

    Adding properties to add payload parameters in network partition

commit e360365caf5d5d4a2f63fba2c11668c64b249e47
Author: Vishanth <vi...@gmail.com>
Date:   2015-04-27T09:03:11Z

    Merge remote-tracking branch 'upstream/master' into payload

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Adding properties to add payload parameters ...

Posted by swgkg <gi...@git.apache.org>.
Github user swgkg commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/289#discussion_r29138259
  
    --- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java ---
    @@ -58,6 +58,7 @@
         private static final Log log = LogFactory.getLog(CloudControllerServiceImpl.class);
     
         private static final String PERSISTENCE_MAPPING = "PERSISTENCE_MAPPING";
    +    public static final String PAYLOAD_PARAMETER = "payload_parameter.";
    --- End diff --
    
    Do we need to have this as public? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Adding properties to add payload parameters ...

Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth commented on the pull request:

    https://github.com/apache/stratos/pull/289#issuecomment-96633215
  
    Closing hence merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Adding properties to add payload parameters ...

Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/289#discussion_r29138312
  
    --- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java ---
    @@ -58,6 +58,7 @@
         private static final Log log = LogFactory.getLog(CloudControllerServiceImpl.class);
     
         private static final String PERSISTENCE_MAPPING = "PERSISTENCE_MAPPING";
    +    public static final String PAYLOAD_PARAMETER = "payload_parameter.";
    --- End diff --
    
    Thanks for pointing it. Yes it should be private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Adding properties to add payload parameters ...

Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth closed the pull request at:

    https://github.com/apache/stratos/pull/289


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---