You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/16 04:50:16 UTC
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#1229: [HUDI-535] Ensure Compaction Plan is always written in .aux folder
to avoid 0.5.0/0.5.1 reader-writer compatibility issues
bvaradar commented on a change in pull request #1229: [HUDI-535] Ensure Compaction Plan is always written in .aux folder to avoid 0.5.0/0.5.1 reader-writer compatibility issues
URL: https://github.com/apache/incubator-hudi/pull/1229#discussion_r367229596
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -369,8 +366,6 @@ public HoodieInstant transitionCleanInflightToComplete(HoodieInstant inflightIns
Preconditions.checkArgument(inflightInstant.getAction().equals(HoodieTimeline.CLEAN_ACTION));
Preconditions.checkArgument(inflightInstant.isInflight());
HoodieInstant commitInstant = new HoodieInstant(State.COMPLETED, CLEAN_ACTION, inflightInstant.getTimestamp());
- // First write metadata to aux folder
Review comment:
Unlike compaction plan, Cleaner Metadata is never read concurrently read and written. Hence, there is no need to write to .aux folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services