You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/01 19:43:01 UTC
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/
-----------------------------------------------------------
(Updated March 1, 2013, 6:43 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Fixe for https://issues.apache.org/jira/browse/MESOS-352.
Can we get this committed to trunk? There is still an open question about how we print output in "run". One of us can take another stab at it in another review.
Description
-------
See Summary.
Also, we only run 'ant' once instead of twice.
This addresses bug MESOS-352.
https://issues.apache.org/jira/browse/MESOS-352
Diffs (updated)
-----
hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
Diff: https://reviews.apache.org/r/9174/diff/
Testing
-------
make hadoop-2.0.0-mr1-cdh4.1.2
make hadoop-0.20.2-cdh3u3
make hadoop-0.20.205.0
Thanks,
Vinod Kone
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/
-----------------------------------------------------------
(Updated March 6, 2013, 2:24 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Updated diff for posterity. No need for review.
Description
-------
See Summary.
Also, we only run 'ant' once instead of twice.
This addresses bug MESOS-352.
https://issues.apache.org/jira/browse/MESOS-352
Diffs (updated)
-----
hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
Diff: https://reviews.apache.org/r/9174/diff/
Testing
-------
make hadoop-2.0.0-mr1-cdh4.1.2
make hadoop-0.20.2-cdh3u3
make hadoop-0.20.205.0
Thanks,
Vinod Kone
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 5, 2013, 11:25 p.m., Benjamin Hindman wrote:
> > hadoop/TUTORIAL.sh, line 267
> > <https://reviews.apache.org/r/9174/diff/10/?file=266585#file266585line267>
> >
> > What about aligning these? I don't know whether or not it's worth obeying style guidelines here for readability, up to you.
I've been aligning line breaks as +2 in this tutorial.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17432
-----------------------------------------------------------
On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 10:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> This addresses bug MESOS-352.
> https://issues.apache.org/jira/browse/MESOS-352
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17432
-----------------------------------------------------------
Ship it!
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36973>
Can kill this now.
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36974>
What about aligning these? I don't know whether or not it's worth obeying style guidelines here for readability, up to you.
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36976>
Maybe a TODO to make these part of the tutorial?
- Benjamin Hindman
On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 10:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> This addresses bug MESOS-352.
> https://issues.apache.org/jira/browse/MESOS-352
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17438
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 10:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> This addresses bug MESOS-352.
> https://issues.apache.org/jira/browse/MESOS-352
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/
-----------------------------------------------------------
(Updated March 5, 2013, 10:39 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's.
Summary (updated)
-----------------
Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Description
-------
See Summary.
Also, we only run 'ant' once instead of twice.
This addresses bug MESOS-352.
https://issues.apache.org/jira/browse/MESOS-352
Diffs (updated)
-----
hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
Diff: https://reviews.apache.org/r/9174/diff/
Testing
-------
make hadoop-2.0.0-mr1-cdh4.1.2
make hadoop-0.20.2-cdh3u3
make hadoop-0.20.205.0
Thanks,
Vinod Kone
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 5, 2013, 8:43 a.m., Benjamin Hindman wrote:
> > hadoop/TUTORIAL.sh, line 39
> > <https://reviews.apache.org/r/9174/diff/9/?file=264055#file264055line39>
> >
> > What is 'cmd'?
ty
> On March 5, 2013, 8:43 a.m., Benjamin Hindman wrote:
> > hadoop/TUTORIAL.sh, line 31
> > <https://reviews.apache.org/r/9174/diff/9/?file=264055#file264055line31>
> >
> > Okay, the original semantics are "kind of" perserved here. In many cases we still ask "Hit enter to continue." we just don't show exactly what we'll be running until AFTER that person hits enter. The weird thing about that is that once you hit enter some stuff might fly by on the screen and it's possible you never actually see the command(s) that got ran to get that output. You might feel compelled to scroll up and try and figure out what the commands actually were but you'll probably just feel overwhelmed. As a teaching aid I'd prefer if we showed the commands BEFORE the user hits enter. I don't see any issues with doing this technically, so rather than push back again I'll just suggest some code here:
> >
> > ===========================================
> >
> > # A helper function to run one or more commands, aborting the tutorial
> > # if any of the commands fail.
> > function run() {
> > for command in "${@}"; do
> > eval ${command}
> >
> > if test "${?}" != 0; then
> > cat <<__EOF__
> >
> > ${RED}Oh no! We failed to run '${command}'. If you need help try emailing:
> >
> > mesos-dev@incubator.apache.org
> >
> > __EOF__
> > exit 1
> > fi
> > done
> > }
> >
> > summary="" # Enables users to reproduce the steps/commands of the tutorial.
> >
> > # A helper function to perform a step of the tutorial (i.e., one or more
> > # commands). Prints the command(s) out before they are run and waits
> > # for the user to confirm. In addition, the commands are appended to
> > # the summary.
> > function perform() {
> > echo
> > for command in "${@}"; do
> > echo " $ ${command}"
> > done
> > echo
> >
> > read -e -p "${BRIGHT}Hit enter to continue.${NORMAL} "
> > echo
> >
> > for command in "${@}"; do
> > run "${command}"
> >
> > # Append to the summary.
> > summary="${summary}
> > $ ${command}"
> > done
> > }
> >
> > perform "echo some command" \
> > "echo another command"
> >
> > perform "echo a later command"
> >
> > run "echo a command that a user doesn't need to run later to \"reproduce\" the tutorial"
> >
> > ===========================================
> >
> > You'd then go and kill all of the
> >
> > read -e -p "${BRIGHT}Hit enter to continue.${NORMAL} "
> > echo
> >
> > blocks and replace with invocations of perform.
thanks! as discussed offline, s/perform/execute/
> On March 5, 2013, 8:43 a.m., Benjamin Hindman wrote:
> > hadoop/TUTORIAL.sh, line 353
> > <https://reviews.apache.org/r/9174/diff/9/?file=264055#file264055line353>
> >
> > This is weird ... you're printing out things and including them in the summary that are not really part of the tutorial. This really begs for a separate helper.
run() now doesn't print summary.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17362
-----------------------------------------------------------
On March 5, 2013, 10:39 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 10:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> This addresses bug MESOS-352.
> https://issues.apache.org/jira/browse/MESOS-352
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9174/#review17362
-----------------------------------------------------------
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36898>
Okay, the original semantics are "kind of" perserved here. In many cases we still ask "Hit enter to continue." we just don't show exactly what we'll be running until AFTER that person hits enter. The weird thing about that is that once you hit enter some stuff might fly by on the screen and it's possible you never actually see the command(s) that got ran to get that output. You might feel compelled to scroll up and try and figure out what the commands actually were but you'll probably just feel overwhelmed. As a teaching aid I'd prefer if we showed the commands BEFORE the user hits enter. I don't see any issues with doing this technically, so rather than push back again I'll just suggest some code here:
===========================================
# A helper function to run one or more commands, aborting the tutorial
# if any of the commands fail.
function run() {
for command in "${@}"; do
eval ${command}
if test "${?}" != 0; then
cat <<__EOF__
${RED}Oh no! We failed to run '${command}'. If you need help try emailing:
mesos-dev@incubator.apache.org
__EOF__
exit 1
fi
done
}
summary="" # Enables users to reproduce the steps/commands of the tutorial.
# A helper function to perform a step of the tutorial (i.e., one or more
# commands). Prints the command(s) out before they are run and waits
# for the user to confirm. In addition, the commands are appended to
# the summary.
function perform() {
echo
for command in "${@}"; do
echo " $ ${command}"
done
echo
read -e -p "${BRIGHT}Hit enter to continue.${NORMAL} "
echo
for command in "${@}"; do
run "${command}"
# Append to the summary.
summary="${summary}
$ ${command}"
done
}
perform "echo some command" \
"echo another command"
perform "echo a later command"
run "echo a command that a user doesn't need to run later to \"reproduce\" the tutorial"
===========================================
You'd then go and kill all of the
read -e -p "${BRIGHT}Hit enter to continue.${NORMAL} "
echo
blocks and replace with invocations of perform.
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36871>
What is 'cmd'?
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36897>
This is weird ... you're printing out things and including them in the summary that are not really part of the tutorial. This really begs for a separate helper.
hadoop/TUTORIAL.sh
<https://reviews.apache.org/r/9174/#comment36899>
These next couple steps probably need some more output around what exactly the tutorial is doing and why.
- Benjamin Hindman
On March 1, 2013, 6:43 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated March 1, 2013, 6:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> This addresses bug MESOS-352.
> https://issues.apache.org/jira/browse/MESOS-352
>
>
> Diffs
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Added support for hadoop-2.0.0-mr1-cdh4.1.2
Posted by Benjamin Mahler <bm...@twitter.com>.
I see the new output style as a regression in the usability of the
tutorial, so
I was holding off on my shipit, can you restore the semantics?
BenH: Feel free to veto me on this! ;)
On Fri, Mar 1, 2013 at 10:43 AM, Vinod Kone <vi...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9174/
> -----------------------------------------------------------
>
> (Updated March 1, 2013, 6:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Changes
> -------
>
> Fixe for https://issues.apache.org/jira/browse/MESOS-352.
>
> Can we get this committed to trunk? There is still an open question about
> how we print output in "run". One of us can take another stab at it in
> another review.
>
>
> Description
> -------
>
> See Summary.
>
> Also, we only run 'ant' once instead of twice.
>
>
> This addresses bug MESOS-352.
> https://issues.apache.org/jira/browse/MESOS-352
>
>
> Diffs (updated)
> -----
>
> hadoop/Makefile.am d1aa75535ab617f9e4a0b8a0db84d77f1916acc4
> hadoop/TUTORIAL.sh 5670d6afa96f858d437f26885e862712bbf72b71
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_hadoop-env.sh.patch PRE-CREATION
> hadoop/hadoop-2.0.0-mr1-cdh4.1.2_mesos.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9174/diff/
>
>
> Testing
> -------
>
> make hadoop-2.0.0-mr1-cdh4.1.2
> make hadoop-0.20.2-cdh3u3
> make hadoop-0.20.205.0
>
>
> Thanks,
>
> Vinod Kone
>
>