[GitHub] [airflow] potiuk commented on a diff in pull request #25306: Strip limits when constructing devel-all

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #25306:
URL: https://github.com/apache/airflow/pull/25306#discussion_r930872679


##########
dev/provider_packages/prepare_provider_packages.py:
##########
@@ -314,7 +314,20 @@ def get_install_requirements(provider_package_id: str, version_suffix: str) -> s
 
     :return: install requirements of the package
     """
-    install_requires = ALL_DEPENDENCIES[provider_package_id][DEPS]
+
+    def apply_version_suffix(install_clause: str) -> str:
+        if install_clause.startswith("apache-airflow") and ">=" in install_clause and version_suffix != "":
+            # This is workaround for `pip` bug. When you specify dependency as >= X.Y.Z, and you
+            # Have packages X.Y.Zdev0 or X.Y.Zrc1, the "=" part does not include the pre-release versions
+            # you need to explicitly specify >= X.Y.Za0 to include pre-release versions.
+            # Therefore, when we are preparing pre-releases we always add a0 for airflow and other providers
+            # to Allow installing two packages released in rc* that depend on each-other

Review Comment:
   Ah. I thought you mentioned before that this was a long standing bug that you never got around to fix, but I must have been mistaken. If -pre works this way, then it is indeed a much better fix, so let me change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org