You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2025/06/08 08:32:52 UTC
[PR] vectorize lookup expression (druid)
clintropolis opened a new pull request, #18096:
URL: https://github.com/apache/druid/pull/18096
### Description
Vectorize the `LookupExpr` (kind of surprised this one wasn't already done).
Also cleaned up `VectorExprSanityTest` (and renamed `VectorExprResultConsistencyTest` to better reflect that it is just comparing that `Expr` and `ExprVectorProcessor` results are identical) to use `Sets.cartesianProduct` since I feel like we were using a super old guava that didn't have it when I wrote this test . Additionally, I deleted `VectorExpressionsSanityTest` and moved it into the newly renamed `VectorExprResultConsistencyTest`, since i'm not sure why a whole file had to exist for 1 function, (and also added timestamp_floor test while I was there).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] vectorize lookup expression (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #18096:
URL: https://github.com/apache/druid/pull/18096#discussion_r2134574897
##########
server/src/test/java/org/apache/druid/query/expression/LookupExprMacroTest.java:
##########
@@ -111,6 +121,81 @@
}
}
+ @Test
+ public void testVectorize()
+ {
+ final Map<String, String> lookup = Map.of(
+ "1", "a",
+ "12", "b",
+ "33", "c",
+ "111", "d",
+ "123", "e",
+ "124", "f"
+ );
+ final Map<String, String> one2one = new HashMap<>()
+ {
+ @Override
+ public String get(Object key)
Review Comment:
## Confusing overloading of methods
Method new HashMap<String,String>(...) {{ ... }}.get(..) could be confused with overloaded method [get](1), since dispatch depends on static types.
Method new LookupExtractorFactoryContainerProvider(...) {{ ... }}.get(..) could be confused with overloaded method [get](1), since dispatch depends on static types.
[Show more details](https://github.com/apache/druid/security/code-scanning/9215)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] vectorize lookup expression (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #18096:
URL: https://github.com/apache/druid/pull/18096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org