You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/02 12:52:56 UTC

[GitHub] [spark] xuanyuanking commented on pull request #30521: [SPARK-33577][SS] Add support for V1Table in stream writer table API

xuanyuanking commented on pull request #30521:
URL: https://github.com/apache/spark/pull/30521#issuecomment-737211661


   ```
   Both must be addressed - I don't think case 2 is rare which can be ignored.
   ```
   For supporting case 2: `table not exists and users want to fail`, seems we can add a default boolean config for `toTable` API to control the table creation. WDYT?
   ```
   def toTable(tableName: String, ifNotExist: Boolean = true): StreamingQuery 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org