You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by brightchen <gi...@git.apache.org> on 2016/04/14 23:23:01 UTC
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
GitHub user brightchen opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/240
SPOI-7818 #resolve #comment Remove dimensions code duplication betwee…
…n megh and malhar
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brightchen/incubator-apex-malhar SPOI-7818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 339f3b63b7c0957069d495a00c1ef5991f352ea1
Author: brightchen <br...@datatorrent.com>
Date: 2016-04-14T01:07:41Z
SPOI-7818 #resolve #comment Remove dimensions code duplication between megh and malhar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/240#discussion_r59809960
--- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterBaseTest.java ---
@@ -97,7 +97,13 @@ protected void starting(org.junit.runner.Description description)
@Override
protected void finished(Description description)
{
- TestUtils.deleteTargetTestClassFolder(description);
+ try {
+ //got RuntimeException: java.io.IOException: Unable to delete directory target/com.datatorrent.lib.io.fs.FileSplitterBaseTest/testSplitterInApp
+ //in build server and sometime in local machine
+ TestUtils.deleteTargetTestClassFolder(description);
--- End diff --
How about a deleteQuietly function if this is frequently needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/240#discussion_r59810546
--- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterBaseTest.java ---
@@ -97,7 +97,13 @@ protected void starting(org.junit.runner.Description description)
@Override
protected void finished(Description description)
{
- TestUtils.deleteTargetTestClassFolder(description);
+ try {
+ //got RuntimeException: java.io.IOException: Unable to delete directory target/com.datatorrent.lib.io.fs.FileSplitterBaseTest/testSplitterInApp
+ //in build server and sometime in local machine
+ TestUtils.deleteTargetTestClassFolder(description);
--- End diff --
deleteQuietly is method of FileUtils, which means we need to duplicate the logic of "new File("target/" + description.getClassName())"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/240#discussion_r59813115
--- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterBaseTest.java ---
@@ -97,7 +97,13 @@ protected void starting(org.junit.runner.Description description)
@Override
protected void finished(Description description)
{
- TestUtils.deleteTargetTestClassFolder(description);
+ try {
+ //got RuntimeException: java.io.IOException: Unable to delete directory target/com.datatorrent.lib.io.fs.FileSplitterBaseTest/testSplitterInApp
+ //in build server and sometime in local machine
+ TestUtils.deleteTargetTestClassFolder(description);
--- End diff --
This is in fact is not related to this task.
Maybe it related to "APEXMALHAR-1991"
But I got the exception at least twice in build server, and got once in my local machine.
It's better to separate this issue. but this task is out of time.
May I can create a bug and merge this task even if this are problem in build server
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by brightchen <gi...@git.apache.org>.
GitHub user brightchen reopened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/240
SPOI-7818 #resolve #comment Remove dimensions code duplication betwee…
…n megh and malhar
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brightchen/incubator-apex-malhar SPOI-7818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 4adddcc02645922f54e07e6dae7f6ac3c4fd9760
Author: brightchen <br...@datatorrent.com>
Date: 2016-04-14T01:07:41Z
SPOI-7818 #resolve #comment Remove dimensions code duplication between megh and malhar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by brightchen <gi...@git.apache.org>.
Github user brightchen closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/240
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: SPOI-7818 #resolve #comment Re...
Posted by brightchen <gi...@git.apache.org>.
GitHub user brightchen reopened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/240
SPOI-7818 #resolve #comment Remove dimensions code duplication betwee…
…n megh and malhar
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brightchen/incubator-apex-malhar SPOI-7818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/240.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #240
----
commit 59972a48f8ae654cc36a066bfc6e75c15785466d
Author: brightchen <br...@datatorrent.com>
Date: 2016-04-14T01:07:41Z
SPOI-7818 #resolve #comment Remove dimensions code duplication between megh and malhar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---