You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Dave Beech (JIRA)" <ji...@apache.org> on 2012/09/22 10:31:08 UTC
[jira] [Created] (AVRO-1171) Configure method is being called twice
on AvroMapper instances
Dave Beech created AVRO-1171:
--------------------------------
Summary: Configure method is being called twice on AvroMapper instances
Key: AVRO-1171
URL: https://issues.apache.org/jira/browse/AVRO-1171
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.7.1
Reporter: Dave Beech
Priority: Minor
The configure method is being called twice on each AvroMapper instance.
The first call is made via reflection, when the instance is created by ReflectionUtils, and the second is made explicitly inside HadoopMapper. I think this second one could be safely removed.
Ref:
http://mail-archives.apache.org/mod_mbox/avro-user/201209.mbox/%3CCAFZSZPuM10yoBvP897ytT5PpAbv-gGFzsvE-kUn-Ue9p4SUJuQ%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1171) Configure method is being called
twice on AvroMapper instances
Posted by "Dave Beech (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461076#comment-13461076 ]
Dave Beech commented on AVRO-1171:
----------------------------------
Same applies for AvroReducer - the second call is in HadoopReducerBase
> Configure method is being called twice on AvroMapper instances
> --------------------------------------------------------------
>
> Key: AVRO-1171
> URL: https://issues.apache.org/jira/browse/AVRO-1171
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.1
> Reporter: Dave Beech
> Priority: Minor
>
> The configure method is being called twice on each AvroMapper instance.
> The first call is made via reflection, when the instance is created by ReflectionUtils, and the second is made explicitly inside HadoopMapper. I think this second one could be safely removed.
> Ref:
> http://mail-archives.apache.org/mod_mbox/avro-user/201209.mbox/%3CCAFZSZPuM10yoBvP897ytT5PpAbv-gGFzsvE-kUn-Ue9p4SUJuQ%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1171) Configure method is being called twice
on AvroMapper instances
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-1171:
-------------------------------
Resolution: Fixed
Fix Version/s: 1.7.3
Assignee: Dave Beech
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Dave!
> Configure method is being called twice on AvroMapper instances
> --------------------------------------------------------------
>
> Key: AVRO-1171
> URL: https://issues.apache.org/jira/browse/AVRO-1171
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.1
> Reporter: Dave Beech
> Assignee: Dave Beech
> Priority: Minor
> Fix For: 1.7.3
>
> Attachments: AVRO-1171.patch
>
>
> The configure method is being called twice on each AvroMapper instance.
> The first call is made via reflection, when the instance is created by ReflectionUtils, and the second is made explicitly inside HadoopMapper. I think this second one could be safely removed.
> Ref:
> http://mail-archives.apache.org/mod_mbox/avro-user/201209.mbox/%3CCAFZSZPuM10yoBvP897ytT5PpAbv-gGFzsvE-kUn-Ue9p4SUJuQ%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1171) Configure method is being called twice
on AvroMapper instances
Posted by "Dave Beech (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Beech updated AVRO-1171:
-----------------------------
Attachment: AVRO-1171.patch
Here's a patch - all tests pass.
> Configure method is being called twice on AvroMapper instances
> --------------------------------------------------------------
>
> Key: AVRO-1171
> URL: https://issues.apache.org/jira/browse/AVRO-1171
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.1
> Reporter: Dave Beech
> Priority: Minor
> Attachments: AVRO-1171.patch
>
>
> The configure method is being called twice on each AvroMapper instance.
> The first call is made via reflection, when the instance is created by ReflectionUtils, and the second is made explicitly inside HadoopMapper. I think this second one could be safely removed.
> Ref:
> http://mail-archives.apache.org/mod_mbox/avro-user/201209.mbox/%3CCAFZSZPuM10yoBvP897ytT5PpAbv-gGFzsvE-kUn-Ue9p4SUJuQ%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1171) Configure method is being called twice
on AvroMapper instances
Posted by "Dave Beech (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Beech updated AVRO-1171:
-----------------------------
Status: Patch Available (was: Open)
> Configure method is being called twice on AvroMapper instances
> --------------------------------------------------------------
>
> Key: AVRO-1171
> URL: https://issues.apache.org/jira/browse/AVRO-1171
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.1
> Reporter: Dave Beech
> Priority: Minor
> Attachments: AVRO-1171.patch
>
>
> The configure method is being called twice on each AvroMapper instance.
> The first call is made via reflection, when the instance is created by ReflectionUtils, and the second is made explicitly inside HadoopMapper. I think this second one could be safely removed.
> Ref:
> http://mail-archives.apache.org/mod_mbox/avro-user/201209.mbox/%3CCAFZSZPuM10yoBvP897ytT5PpAbv-gGFzsvE-kUn-Ue9p4SUJuQ%40mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira