You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Danny Chen (Jira)" <ji...@apache.org> on 2020/02/21 04:56:00 UTC

[jira] [Resolved] (CALCITE-3812) Refactor HintStrategy to HintPredicate

     [ https://issues.apache.org/jira/browse/CALCITE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Danny Chen resolved CALCITE-3812.
---------------------------------
    Resolution: Fixed

Fixed in [2515e9f|https://github.com/apache/calcite/commit/2515e9ff12a588a590f408b3660a96c3fa76cc01] !

> Refactor HintStrategy to HintPredicate
> --------------------------------------
>
>                 Key: CALCITE-3812
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3812
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The HintStrategy was introduced in commit https://github.com/apache/calcite/commit/52bc246d5e07510689635f407f4d9dc494b0af4d, at that moment, we can only define the hint match rules for propagation, and the class name is okey.
> But with more components added to the HintStrategyTable(i.e. the HintOptionChecker, the error hander, the excluded rules), i found the "HintStrategy" is mis-leading.
> So i propose to rename HintStrategy to HintPredicate and HintStrategyTable.Entry to HintStrategy.
> I want this change to be included in 1.22.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)