[GitHub] [iceberg] rdblue commented on a change in pull request #1508: Use schema at the time of the snapshot when reading a snapshot.

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r496934142



##########
File path: api/src/main/java/org/apache/iceberg/Table.java
##########
@@ -51,6 +51,23 @@
    */
   Schema schema();
 
+  /**
+   * Return the {@link Schema schema} for this table at the time of the snapshot
+   * specified by the snapshotId.
+   *
+   * @return this table's schema
+   */
+  Schema schemaForSnapshot(long snapshotId);
+
+  /**
+   * Return the {@link Schema schema} for this table at the time of the most recent
+   * snapshot as of the specified timestampMillis.
+   * Note: This is not necessarily the schema at the time of the specified timestampMillis.
+   *
+   * @return this table's schema
+   */
+  Schema schemaForSnapshotAsOfTime(long timestampMillis);

Review comment:
       Instead of changing the table API in this commit, I think we only need to add a `schema` method to `Snapshot`. That will be used later when we have better tracking. Not adding too many methods to the public API in this commit will give us more flexibility later and make this simpler to get in.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org