[jira] [Commented] (SLING-7759) add other "patterns" than path for filters

["Julian Sedding (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529541#comment-16529541 ] 

Julian Sedding commented on SLING-7759:
---------------------------------------

Could we try making the naming and mechanism consistent with Servlets?

Drop the {{pattern}} part from any new properties, i.e. name them {{sling.servlet.*}} and use the plural form of {{paths}}, {{selectors}} etc. and of course allow setting multiple values for them. 

- {{sling.filter.paths}}
- {{sling.filter.resourceTypes}}
- {{sling.filter.selectors}}
- {{sling.filter.extensions}}
- {{sling.filter.methods}}
- {{sling.filter.prefix}}

Compare with the [servlet  registration properties|http://sling.apache.org/documentation/the-sling-engine/servlets.html#servlet-registration].

> add other "patterns" than path for filters
> ------------------------------------------
>
>                 Key: SLING-7759
>                 URL: https://issues.apache.org/jira/browse/SLING-7759
>             Project: Sling
>          Issue Type: Improvement
>          Components: Engine
>    Affects Versions: Engine 2.6.12
>            Reporter: Nicolas Peltier
>            Assignee: Nicolas Peltier
>            Priority: Major
>
> adding additional patterns to filters (right now {{sling.filter.pattern}} allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy &  add sling.filter.pattern.path for consistency with what follow) regexp matches current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix  passes if sling.filter.pattern.suffix regep matches current suffix



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)