You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2013/03/05 20:42:13 UTC

[jira] [Commented] (HBASE-8008) Fix DirFilter usage to be consistent

    [ https://issues.apache.org/jira/browse/HBASE-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593814#comment-13593814 ] 

Ted Yu commented on HBASE-8008:
-------------------------------

{code}
+   * A {@link PathFilter} that returns usertable directories. To get all directories use the
+   * {@link BlackListDirFilter} with a <tt>null</tt> blacklist
+   */
+  public static class DirFilter extends BlackListDirFilter {
+
+    public DirFilter(FileSystem fs) {
+      super(fs, null);
+    }
+  }
+
+  /**
+   * A {@link PathFilter} that returns usertable directories. To get all directories use the
+   * {@link BlackListDirFilter} with a <tt>null</tt> blacklist
+   */
+  public static class UseTableDirFilter extends BlackListDirFilter {
+
+    public UseTableDirFilter(FileSystem fs) {
+      super(fs, HConstants.HBASE_NON_USER_TABLE_DIRS);
{code}
The javadoc for both methods seems to be the same.

For UseTableDirFilter, I guess you meant UserTableDirFilter
                
> Fix DirFilter usage to be consistent
> ------------------------------------
>
>                 Key: HBASE-8008
>                 URL: https://issues.apache.org/jira/browse/HBASE-8008
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0
>
>         Attachments: hbase-8008-r0.patch
>
>
> Currently the DirFilter automatically filters out HConstants.HBASE_NON_USER_TABLE_DIRS, which is not needed in most cases. We should switch the usage so people actually using a directory filter and then have a special filter when looking for tables specifically.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira