You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "viktorsomogyi (via GitHub)" <gi...@apache.org> on 2023/06/08 15:34:23 UTC
[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception
viktorsomogyi commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1219754042
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -447,11 +447,11 @@ class Partition(val topicPartition: TopicPartition,
private[cluster] def createLog(isNew: Boolean, isFutureReplica: Boolean, offsetCheckpoints: OffsetCheckpoints, topicId: Option[Uuid]): UnifiedLog = {
def updateHighWatermark(log: UnifiedLog): Unit = {
val checkpointHighWatermark = offsetCheckpoints.fetch(log.parentDir, topicPartition).getOrElse {
- info(s"No checkpointed highwatermark is found for partition $topicPartition")
+ info(s"No checkpointed highwatermark is found for ${if (isFutureReplica) "Future partition" else "partition"} $topicPartition")
Review Comment:
nit: "future" not "Future"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org