[GitHub] [trafficcontrol] zrhoffman commented on a diff in pull request #7314: Add capability to Delivery Service (HTTP, DNS)

["zrhoffman (via GitHub)" <gi...@apache.org>]

zrhoffman commented on code in PR #7314:
URL: https://github.com/apache/trafficcontrol/pull/7314#discussion_r1106266404


##########
traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html:
##########
@@ -343,6 +342,34 @@ <h3 ng-if="!open()">Previous Value</h3>
                             </div>
                         </div>
                     </div>
+                    <div class="form-group" ng-class="{'has-error': hasError(generalConfig.requiredCapabilities), 'has-feedback': hasError(generalConfig.requiredCapabilities)}">
+                        <label class="has-tooltip control-label col-md-2 col-sm-2 col-xs-12" for="capability">Required Capability
+                            <div class="helptooltip">
+                                <div class="helptext">Required capability(ies) associated with a delivery  service</div>
+                            </div>
+                        </label>
+                        <div class="col-md-10 col-sm-10 col-xs-12">
+                            <div class="checkbox-scroll-container">
+                                <div ng-repeat="capability in requiredCapabilities">
+                                    <input
+                                            type="checkbox"
+                                            id="capability"
+                                            name="capability"
+                                            ng-model="selectedCapabilities[capability.name]"
+                                            ng-checked="selectedCapabilities[capability.name]"
+                                    />
+                                    <label>
+                                        <a ng-href="/#!/server-capabilities/edit?name={{capability.name}}" target="_blank"> {{capability.name}}</a>
+                                    </label>

Review Comment:
   Moving `.has-tooltip` of of the label breaks the dotted underline. So the underline should be re-added to the label somehow.
   
   https://github.com/apache/trafficcontrol/blob/dad57721e2a82ad0fb5eb1d30ba2ca33542d68ec/traffic_portal/app/src/common/modules/form/_form.scss#L116-L117



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org