You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by db...@apache.org on 2006/09/27 20:44:47 UTC
svn commit: r450540 - in /xerces/c/branches/xerces-2.7/src/xercesc:
internal/BinFileOutputStream.cpp util/BinFileInputStream.cpp
Author: dbertoni
Date: Wed Sep 27 11:44:46 2006
New Revision: 450540
URL: http://svn.apache.org/viewvc?view=rev&rev=450540
Log:
Fixed some bugs where the literal 0 was being used as the value of an invalid file handle. This affects platforms like Solaris, which use open/close, etc., instead of fopen/fclose, etc.
Modified:
xerces/c/branches/xerces-2.7/src/xercesc/internal/BinFileOutputStream.cpp
xerces/c/branches/xerces-2.7/src/xercesc/util/BinFileInputStream.cpp
Modified: xerces/c/branches/xerces-2.7/src/xercesc/internal/BinFileOutputStream.cpp
URL: http://svn.apache.org/viewvc/xerces/c/branches/xerces-2.7/src/xercesc/internal/BinFileOutputStream.cpp?view=diff&rev=450540&r1=450539&r2=450540
==============================================================================
--- xerces/c/branches/xerces-2.7/src/xercesc/internal/BinFileOutputStream.cpp (original)
+++ xerces/c/branches/xerces-2.7/src/xercesc/internal/BinFileOutputStream.cpp Wed Sep 27 11:44:46 2006
@@ -35,14 +35,14 @@
// ---------------------------------------------------------------------------
BinFileOutputStream::~BinFileOutputStream()
{
- if (fSource)
+ if (getIsOpen())
XMLPlatformUtils::closeFile(fSource, fMemoryManager);
}
BinFileOutputStream::BinFileOutputStream(const XMLCh* const fileName
, MemoryManager* const manager)
-:fSource(0)
+:fSource(XERCES_Invalid_File_Handle)
,fMemoryManager(manager)
{
fSource = XMLPlatformUtils::openFileToWrite(fileName, manager);
@@ -50,7 +50,7 @@
BinFileOutputStream::BinFileOutputStream(const char* const fileName
, MemoryManager* const manager)
-:fSource(0)
+:fSource(XERCES_Invalid_File_Handle)
,fMemoryManager(manager)
{
// Transcode the file name and put a janitor on the temp buffer
Modified: xerces/c/branches/xerces-2.7/src/xercesc/util/BinFileInputStream.cpp
URL: http://svn.apache.org/viewvc/xerces/c/branches/xerces-2.7/src/xercesc/util/BinFileInputStream.cpp?view=diff&rev=450540&r1=450539&r2=450540
==============================================================================
--- xerces/c/branches/xerces-2.7/src/xercesc/util/BinFileInputStream.cpp (original)
+++ xerces/c/branches/xerces-2.7/src/xercesc/util/BinFileInputStream.cpp Wed Sep 27 11:44:46 2006
@@ -36,7 +36,7 @@
BinFileInputStream::BinFileInputStream(const XMLCh* const fileName
, MemoryManager* const manager) :
- fSource(0)
+ fSource(XERCES_Invalid_File_Handle)
, fMemoryManager(manager)
{
// Try to open the file
@@ -67,7 +67,7 @@
BinFileInputStream::~BinFileInputStream()
{
- if (fSource)
+ if (getIsOpen())
XMLPlatformUtils::closeFile(fSource, fMemoryManager);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org