You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/03 08:19:09 UTC
[GitHub] [dubbo-go] JiaLiangoooo opened a new issue #905: URLEqual 未比较IP Address
JiaLiangoooo opened a new issue #905:
URL: https://github.com/apache/dubbo-go/issues/905
**What happened**:
注册中心：consul
环境：k8s
因为consul的上下线，是全量推的，目前代码逻辑中存在，如果有服务上线或者下线都会往Listener发送Event.
目前存在一种场景，如果先上线的，会同时出现2个provider，因为对比逻辑存在问题，导致上下线Event发送不出去. Invoker更新不了，服务不可用
**What you expected to happen**: 修改URLEqual，新增一个比较IP的操作
**How to reproduce it (as minimally and precisely as possible)**: 平凡上下线会导致这个问题.
**Anything else we need to know?**:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #905:
URL: https://github.com/apache/dubbo-go/issues/905#issuecomment-739189948
@JiaLiangoooo @georgehao
- 提交了一个pr https://github.com/apache/dubbo-go/pull/911 ，有空看看有没有问题。
- 其他的注册中心也检查了一下，他们的比较都是基于url的全量比较（使用`url.String()`, `reflect.DeepEqual()`比较，或者注册中心返回的消息带有删除或更新），所以应该不会有类似consul的问题。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on issue #905:
URL: https://github.com/apache/dubbo-go/issues/905#issuecomment-739101616
@georgehao 😆 这个方法在后续版本中有，当前版本中没有，如果在将比较换成 `common.IsEquals`, 确实能解决这个问题.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge closed issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
gaoxinge closed issue #905:
URL: https://github.com/apache/dubbo-go/issues/905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] gaoxinge commented on issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
gaoxinge commented on issue #905:
URL: https://github.com/apache/dubbo-go/issues/905#issuecomment-747860636
修改已经合并到develop分支了。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on issue #905:
URL: https://github.com/apache/dubbo-go/issues/905#issuecomment-739254998
@gaoxinge 应该没问题了.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] JiaLiangoooo commented on issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
JiaLiangoooo commented on issue #905:
URL: https://github.com/apache/dubbo-go/issues/905#issuecomment-738500566
1. 我能否删除上面的IP与Port的赋值？
2. Copy这份代码，在registry consul listener.go里面增加这个判断？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] georgehao commented on issue #905: URLEqual 未比较IP Address
Posted by GitBox <gi...@apache.org>.
georgehao commented on issue #905:
URL: https://github.com/apache/dubbo-go/issues/905#issuecomment-738769130
`common.IsEquals`应该能满足你的需求.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org