You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Stanton Sievers <si...@gmail.com> on 2012/04/24 18:46:09 UTC

Review Request: Update EhCache configuration to use pooled resources for cache sizing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/
-----------------------------------------------------------

Review request for shindig.

Summary
-------

See the JIRA for the high-level overview.

I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig. I've tried to pick configuration that makes sense for most simple deployments.

I'm also looking for feedback on how to best configure the SizeOf filter. Right now I'm setting it in the system properties from the provider code but could just as easily set it in the web.xml. I have it in the provider code today because that's where we read in the rest of the config. Will security manager's in real world deployments block the call to System.getProperties().put()?

This addresses bug SHINDIG-1746.
https://issues.apache.org/jira/browse/SHINDIG-1746

Diffs
-----

http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java 1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1329784
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java 1329784
http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784

Diff: https://reviews.apache.org/r/4856/diff

Testing
-------

Existing tests pass with the update. I'm not sure what else can be tested via JUnit for these changes.

In testing I did utilize JMX and heap dump analysis to understand and verify that caches were being allocated appropriately. I have documented the steps I took and will publish a wiki article once these changes are in.

Thanks,

Stanton

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Stanton Sievers <si...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/#review7312
-----------------------------------------------------------

Ship it!


Committed revision 1331512.

- Stanton


On 2012-04-25 13:01:08, Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4856/
> -----------------------------------------------------------
> 
> (Updated 2012-04-25 13:01:08)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> See the JIRA for the high-level overview.
> 
> I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig.  I've tried to pick configuration that makes sense for most simple deployments.  
> 
> I'm also looking for feedback on how to best configure the SizeOf filter.  Right now I'm setting it in the system properties from the provider code but could just as easily set it in the web.xml.  I have it in the provider code today because that's where we read in the rest of the config.  Will security manager's in real world deployments block the call to System.getProperties().put()?
> 
> More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page
> 
> 
> This addresses bug SHINDIG-1746.
>     https://issues.apache.org/jira/browse/SHINDIG-1746
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784 
> 
> Diff: https://reviews.apache.org/r/4856/diff
> 
> 
> Testing
> -------
> 
> Existing tests pass with the update.  I'm not sure what else can be tested via JUnit for these changes.
> 
> In testing I did utilize JMX and heap dump analysis to understand and verify that caches were being allocated appropriately.  I have documented the steps I took and will publish a wiki article once these changes are in.
> 
> 
> Thanks,
> 
> Stanton
> 
>

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Stanton Sievers <si...@gmail.com>.

(Updated 2012-04-25 13:01:08.796385)

Review request for shindig.

Changes
-------

Updates to allow res:// and file:// style URLs for the filter path. Added comments and license to SizeOfFilter.txt.

Summary
-------

See the JIRA for the high-level overview.

I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig. I've tried to pick configuration that makes sense for most simple deployments.

More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page

This addresses bug SHINDIG-1746.
https://issues.apache.org/jira/browse/SHINDIG-1746

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/4856/diff

Testing
-------

Existing tests pass with the update. I'm not sure what else can be tested via JUnit for these changes.

Thanks,

Stanton

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Ryan Baxter <rb...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/#review7188
-----------------------------------------------------------



http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt
<https://reviews.apache.org/r/4856/#comment15871>

    Can you add any comments to this file?  I am not sure if EHCache will allow that but if so you might want to.  It would also be good to add the Apache license if you can.


- Ryan


On 2012-04-24 16:50:33, Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4856/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 16:50:33)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> See the JIRA for the high-level overview.
> 
> I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig.  I've tried to pick configuration that makes sense for most simple deployments.  
> 
> I'm also looking for feedback on how to best configure the SizeOf filter.  Right now I'm setting it in the system properties from the provider code but could just as easily set it in the web.xml.  I have it in the provider code today because that's where we read in the rest of the config.  Will security manager's in real world deployments block the call to System.getProperties().put()?
> 
> More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page
> 
> 
> This addresses bug SHINDIG-1746.
>     https://issues.apache.org/jira/browse/SHINDIG-1746
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784 
> 
> Diff: https://reviews.apache.org/r/4856/diff
> 
> 
> Testing
> -------
> 
> Existing tests pass with the update.  I'm not sure what else can be tested via JUnit for these changes.
> 
> In testing I did utilize JMX and heap dump analysis to understand and verify that caches were being allocated appropriately.  I have documented the steps I took and will publish a wiki article once these changes are in.
> 
> 
> Thanks,
> 
> Stanton
> 
>

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Henry Saputra <hs...@apache.org>.


> On 2012-04-24 18:53:41, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties, line 126
> > <https://reviews.apache.org/r/4856/diff/2/?file=104108#file104108line126>
> >
> >     I think we should allow res:// in the URI for consistency and handle conversion in the server side instead.
> 
> Stanton Sievers wrote:
>     Because I have to pass this URI off to EhCache via a system property, the best I could do is check if the URI starts with res:// and then strip it off.  I can spend more time digging into how EhCache is finding these resources if that would be worthwhile.

Yeah thats what I was thinking, just stripped out the res:// which means internal file. Just add comment about the need to check for res://


- Henry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/#review7180
-----------------------------------------------------------


On 2012-04-24 16:50:33, Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4856/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 16:50:33)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> See the JIRA for the high-level overview.
> 
> I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig.  I've tried to pick configuration that makes sense for most simple deployments.  
> 
> I'm also looking for feedback on how to best configure the SizeOf filter.  Right now I'm setting it in the system properties from the provider code but could just as easily set it in the web.xml.  I have it in the provider code today because that's where we read in the rest of the config.  Will security manager's in real world deployments block the call to System.getProperties().put()?
> 
> More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page
> 
> 
> This addresses bug SHINDIG-1746.
>     https://issues.apache.org/jira/browse/SHINDIG-1746
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784 
> 
> Diff: https://reviews.apache.org/r/4856/diff
> 
> 
> Testing
> -------
> 
> Existing tests pass with the update.  I'm not sure what else can be tested via JUnit for these changes.
> 
> In testing I did utilize JMX and heap dump analysis to understand and verify that caches were being allocated appropriately.  I have documented the steps I took and will publish a wiki article once these changes are in.
> 
> 
> Thanks,
> 
> Stanton
> 
>

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Stanton Sievers <si...@gmail.com>.


> On 2012-04-24 18:53:41, Henry Saputra wrote:
> > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties, line 126
> > <https://reviews.apache.org/r/4856/diff/2/?file=104108#file104108line126>
> >
> >     I think we should allow res:// in the URI for consistency and handle conversion in the server side instead.

Because I have to pass this URI off to EhCache via a system property, the best I could do is check if the URI starts with res:// and then strip it off.  I can spend more time digging into how EhCache is finding these resources if that would be worthwhile.


- Stanton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/#review7180
-----------------------------------------------------------


On 2012-04-24 16:50:33, Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4856/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 16:50:33)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> See the JIRA for the high-level overview.
> 
> I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig.  I've tried to pick configuration that makes sense for most simple deployments.  
> 
> I'm also looking for feedback on how to best configure the SizeOf filter.  Right now I'm setting it in the system properties from the provider code but could just as easily set it in the web.xml.  I have it in the provider code today because that's where we read in the rest of the config.  Will security manager's in real world deployments block the call to System.getProperties().put()?
> 
> More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page
> 
> 
> This addresses bug SHINDIG-1746.
>     https://issues.apache.org/jira/browse/SHINDIG-1746
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784 
> 
> Diff: https://reviews.apache.org/r/4856/diff
> 
> 
> Testing
> -------
> 
> Existing tests pass with the update.  I'm not sure what else can be tested via JUnit for these changes.
> 
> In testing I did utilize JMX and heap dump analysis to understand and verify that caches were being allocated appropriately.  I have documented the steps I took and will publish a wiki article once these changes are in.
> 
> 
> Thanks,
> 
> Stanton
> 
>

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Henry Saputra <hs...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4856/#review7180
-----------------------------------------------------------



http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
<https://reviews.apache.org/r/4856/#comment15845>

    I think we should allow res:// in the URI for consistency and handle conversion in the server side instead.


- Henry


On 2012-04-24 16:50:33, Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4856/
> -----------------------------------------------------------
> 
> (Updated 2012-04-24 16:50:33)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> See the JIRA for the high-level overview.
> 
> I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig.  I've tried to pick configuration that makes sense for most simple deployments.  
> 
> I'm also looking for feedback on how to best configure the SizeOf filter.  Right now I'm setting it in the system properties from the provider code but could just as easily set it in the web.xml.  I have it in the provider code today because that's where we read in the rest of the config.  Will security manager's in real world deployments block the call to System.getProperties().put()?
> 
> More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page
> 
> 
> This addresses bug SHINDIG-1746.
>     https://issues.apache.org/jira/browse/SHINDIG-1746
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhConfiguredCache.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/SizeOfFilter.txt PRE-CREATION 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java 1329784 
>   http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1329784 
> 
> Diff: https://reviews.apache.org/r/4856/diff
> 
> 
> Testing
> -------
> 
> Existing tests pass with the update.  I'm not sure what else can be tested via JUnit for these changes.
> 
> In testing I did utilize JMX and heap dump analysis to understand and verify that caches were being allocated appropriately.  I have documented the steps I took and will publish a wiki article once these changes are in.
> 
> 
> Thanks,
> 
> Stanton
> 
>

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

Posted by Stanton Sievers <si...@gmail.com>.

(Updated 2012-04-24 16:50:33.297251)

Review request for shindig.

Changes
-------

Added cross-link to EhCache forum post with some issues.

Summary (updated)
-------

See the JIRA for the high-level overview.

I'm looking for feedback on how to best configure EhCache out-of-the-box for Shindig. I've tried to pick configuration that makes sense for most simple deployments.

More info on some of the issues I ran into and the approaches I took prior to this: http://forums.terracotta.org/forums/posts/list/6940.page

This addresses bug SHINDIG-1746.
https://issues.apache.org/jira/browse/SHINDIG-1746

Diffs
-----

Diff: https://reviews.apache.org/r/4856/diff

Testing
-------

Existing tests pass with the update. I'm not sure what else can be tested via JUnit for these changes.

Thanks,

Stanton