You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2022/10/13 21:35:31 UTC
[GitHub] [tika] nddipiazza opened a new pull request, #742: TIKA-3879 - add s3 testcontainers integration test
nddipiazza opened a new pull request, #742:
URL: https://github.com/apache/tika/pull/742
# add s3 tika pipes integration tests
add integration test for s3 pipe iterator, s3 fetcher, and s3 emitter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on pull request #742: TIKA-3879 - add s3 testcontainers integration test
Posted by GitBox <gi...@apache.org>.
tballison commented on PR #742:
URL: https://github.com/apache/tika/pull/742#issuecomment-1278224792
Couple of really small things. Thank you so much for getting this rolling!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] nddipiazza merged pull request #742: TIKA-3879 - add s3 testcontainers integration test
Posted by GitBox <gi...@apache.org>.
nddipiazza merged PR #742:
URL: https://github.com/apache/tika/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on a diff in pull request #742: TIKA-3879 - add s3 testcontainers integration test
Posted by GitBox <gi...@apache.org>.
tballison commented on code in PR #742:
URL: https://github.com/apache/tika/pull/742#discussion_r995161476
##########
tika-pipes/tika-emitters/tika-emitter-s3/src/main/java/org/apache/tika/pipes/emitter/s3/S3Emitter.java:
##########
@@ -16,33 +16,19 @@
*/
package org.apache.tika.pipes.emitter.s3;
-import static org.apache.tika.config.TikaConfig.mustNotBeEmpty;
Review Comment:
Import order had to be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] tballison commented on a diff in pull request #742: TIKA-3879 - add s3 testcontainers integration test
Posted by GitBox <gi...@apache.org>.
tballison commented on code in PR #742:
URL: https://github.com/apache/tika/pull/742#discussion_r995161152
##########
tika-integration-tests/tika-pipes-s3-integration-tests/src/test/java/org/apache/tika/pipes/s3/tests/S3PipeIntegrationTest.java:
##########
@@ -0,0 +1,144 @@
+package org.apache.tika.pipes.s3.tests;
Review Comment:
Probably need a license on this? checkstyle should have complained!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] nddipiazza commented on a diff in pull request #742: TIKA-3879 - add s3 testcontainers integration test
Posted by GitBox <gi...@apache.org>.
nddipiazza commented on code in PR #742:
URL: https://github.com/apache/tika/pull/742#discussion_r995166742
##########
tika-pipes/tika-emitters/tika-emitter-s3/src/main/java/org/apache/tika/pipes/emitter/s3/S3Emitter.java:
##########
@@ -16,33 +16,19 @@
*/
package org.apache.tika.pipes.emitter.s3;
-import static org.apache.tika.config.TikaConfig.mustNotBeEmpty;
Review Comment:
ah yeah. i'm getting fired up on a new laptop with new everything. so i'm setting up my checkstyle profile now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org