You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/08/14 03:41:29 UTC

[GitHub] [pinot] shenyu0127 opened a new pull request, #11340: Add a test for CASE WHEN scalar function.

shenyu0127 opened a new pull request, #11340:
URL: https://github.com/apache/pinot/pull/11340

   In the test, all the arguments in the CASE WHEN are literal, so the query is rewritten by `CompileTimeFunctionsInvoker`, which calls the CASE WHEN scalar function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] codecov-commenter commented on pull request #11340: Add a test for CASE WHEN scalar function.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11340:
URL: https://github.com/apache/pinot/pull/11340#issuecomment-1676664262

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#11340](https://app.codecov.io/gh/apache/pinot/pull/11340?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e9cc6ad) into [master](https://app.codecov.io/gh/apache/pinot/commit/f25f3ed1f242513b90207d082fb80dbfdc9b06f6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f25f3ed) will **decrease** coverage by `53.82%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #11340       +/-   ##
   =============================================
   - Coverage     68.46%   14.64%   -53.82%     
   + Complexity     6535      494     -6041     
   =============================================
     Files          2233     2159       -74     
     Lines        119952   116795     -3157     
     Branches      18191    17745      -446     
   =============================================
   - Hits          82128    17110    -65018     
   - Misses        31984    98270    +66286     
   + Partials       5840     1415     -4425     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | integration1 | `?` | |
   | integration2 | `?` | |
   | java-11 | `?` | |
   | java-17 | `?` | |
   | java-20 | `14.64% <ø> (-53.65%)` | :arrow_down: |
   | temurin | `14.64% <ø> (-53.82%)` | :arrow_down: |
   | unittests1 | `?` | |
   | unittests2 | `14.64% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 1710 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11340/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] Jackie-Jiang merged pull request #11340: Add a test for CASE WHEN scalar function.

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11340:
URL: https://github.com/apache/pinot/pull/11340


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org