You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by Roshan Weerasuriya <ro...@opensource.lk> on 2004/08/06 11:39:53 UTC
Re: [jira] Created: (AXISCPP-120)
BasicNode::getAttribute(prefix,name)
hi John,
I too agree with this. Since you have requested the method with the
prefix|name pair, do you have any issues in completely removing it and
supporting only the correct version of it which is namespaceURI|name
pair?
Roshan
On Fri, 2004-08-06 at 15:15, Sanjiva Weerawarana wrote:
> Hi Roshan,
>
> getAttr(prefix,name) doesn't make sense .. the prefix means
> nothing without the namespace name it maps to. Just blinding
> returning an attr that happens to have that prefix may work
> sometimes but will undoubtedly lead to bugs. Better get the
> consumer to do it right rather than letting them shoot themselves
> in the foot!
>
> I suggest removing that completely.
>
> Thanks for adding the other method!
>
> Sanjiva.
>
> ----- Original Message -----
> From: "Roshan Weerasuriya" <ro...@opensource.lk>
> To: "Apache AXIS C Developers List" <ax...@ws.apache.org>
> Sent: Friday, August 06, 2004 1:27 PM
> Subject: Re: [jira] Created: (AXISCPP-120)
> BasicNode::getAttribute(prefix,name)
>
>
> > hi,
> >
> > The test case for this implementation is also added to <CVS_HEAD>/
> > tests/client/soapHeader/test10. I tested it on Linux.
> >
> > Roshan
> >
> > On Fri, 2004-08-06 at 12:05, Roshan Weerasuriya wrote:
> > > hi John,
> > >
> > > I guess mostly it would be used as BasicNode::getAttribute(namespaceURI,
> > > name) insted of BasicNode::getAttribute(prefix, name). But since you
> > > have reqested the prefix,name pair I added code to support both of them.
> > >
> > > Roshan
> > >
> > > On Thu, 2004-08-05 at 19:39, axis-c-dev@ws.apache.org wrote:
> > > > Message:
> > > >
> > > > A new issue has been created in JIRA.
> > > >
> > > > ---------------------------------------------------------------------
> > > > View the issue:
> > > > http://issues.apache.org/jira/browse/AXISCPP-120
> > > >
> > > > Here is an overview of the issue:
> > > > ---------------------------------------------------------------------
> > > > Key: AXISCPP-120
> > > > Summary: BasicNode::getAttribute(prefix, name)
> > > > Type: New Feature
> > > >
> > > > Status: Unassigned
> > > > Priority: Major
> > > >
> > > > Project: Axis-C++
> > > > Fix Fors:
> > > > 1.3 Beta
> > > > Versions:
> > > > 1.3 Beta
> > > >
> > > > Assignee:
> > > > Reporter: John Hawkins
> > > >
> > > > Created: Thu, 5 Aug 2004 6:38 AM
> > > > Updated: Thu, 5 Aug 2004 6:38 AM
> > > > Due: Mon, 16 Aug 2004 12:00 AM
> > > >
> > > > Description:
> > > > Would like this function ->
> > > > BasicNode::getAttribute(prefix, name)
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > JIRA INFORMATION:
> > > > This message is automatically generated by JIRA.
> > > >
> > > > If you think it was sent incorrectly contact one of the
> administrators:
> > > > http://issues.apache.org/jira/secure/Administrators.jspa
> > > >
> > > > If you want more information on JIRA, or have a bug to report see:
> > > > http://www.atlassian.com/software/jira
> > > >
> > > >
> > >
> > >
> >
> >
>
>
Re: [jira] Created: (AXISCPP-120) BasicNode::getAttribute(prefix,name)
Posted by John Hawkins <HA...@uk.ibm.com>.
It makes sense to me too !
It's probably a bit harder to implement though :-(
Thanks for the logic check!
John Hawkins
Roshan
Weerasuriya
<roshan@opensourc To
e.lk> Apache AXIS C Developers List
<ax...@ws.apache.org>
06/08/2004 10:39 cc
Subject
Please respond to Re: [jira] Created: (AXISCPP-120)
"Apache AXIS C BasicNode::getAttribute(prefix,name
Developers List" )
hi John,
I too agree with this. Since you have requested the method with the
prefix|name pair, do you have any issues in completely removing it and
supporting only the correct version of it which is namespaceURI|name
pair?
Roshan
On Fri, 2004-08-06 at 15:15, Sanjiva Weerawarana wrote:
> Hi Roshan,
>
> getAttr(prefix,name) doesn't make sense .. the prefix means
> nothing without the namespace name it maps to. Just blinding
> returning an attr that happens to have that prefix may work
> sometimes but will undoubtedly lead to bugs. Better get the
> consumer to do it right rather than letting them shoot themselves
> in the foot!
>
> I suggest removing that completely.
>
> Thanks for adding the other method!
>
> Sanjiva.
>
> ----- Original Message -----
> From: "Roshan Weerasuriya" <ro...@opensource.lk>
> To: "Apache AXIS C Developers List" <ax...@ws.apache.org>
> Sent: Friday, August 06, 2004 1:27 PM
> Subject: Re: [jira] Created: (AXISCPP-120)
> BasicNode::getAttribute(prefix,name)
>
>
> > hi,
> >
> > The test case for this implementation is also added to <CVS_HEAD>/
> > tests/client/soapHeader/test10. I tested it on Linux.
> >
> > Roshan
> >
> > On Fri, 2004-08-06 at 12:05, Roshan Weerasuriya wrote:
> > > hi John,
> > >
> > > I guess mostly it would be used as
BasicNode::getAttribute(namespaceURI,
> > > name) insted of BasicNode::getAttribute(prefix, name). But since you
> > > have reqested the prefix,name pair I added code to support both of
them.
> > >
> > > Roshan
> > >
> > > On Thu, 2004-08-05 at 19:39, axis-c-dev@ws.apache.org wrote:
> > > > Message:
> > > >
> > > > A new issue has been created in JIRA.
> > > >
> > > >
---------------------------------------------------------------------
> > > > View the issue:
> > > > http://issues.apache.org/jira/browse/AXISCPP-120
> > > >
> > > > Here is an overview of the issue:
> > > >
---------------------------------------------------------------------
> > > > Key: AXISCPP-120
> > > > Summary: BasicNode::getAttribute(prefix, name)
> > > > Type: New Feature
> > > >
> > > > Status: Unassigned
> > > > Priority: Major
> > > >
> > > > Project: Axis-C++
> > > > Fix Fors:
> > > > 1.3 Beta
> > > > Versions:
> > > > 1.3 Beta
> > > >
> > > > Assignee:
> > > > Reporter: John Hawkins
> > > >
> > > > Created: Thu, 5 Aug 2004 6:38 AM
> > > > Updated: Thu, 5 Aug 2004 6:38 AM
> > > > Due: Mon, 16 Aug 2004 12:00 AM
> > > >
> > > > Description:
> > > > Would like this function ->
> > > > BasicNode::getAttribute(prefix, name)
> > > >
> > > >
> > > >
---------------------------------------------------------------------
> > > > JIRA INFORMATION:
> > > > This message is automatically generated by JIRA.
> > > >
> > > > If you think it was sent incorrectly contact one of the
> administrators:
> > > > http://issues.apache.org/jira/secure/Administrators.jspa
> > > >
> > > > If you want more information on JIRA, or have a bug to report see:
> > > > http://www.atlassian.com/software/jira
> > > >
> > > >
> > >
> > >
> >
> >
>
>