You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/07/08 09:37:49 UTC
Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java ad27d78e1839fa60df8f2429901b77221be71653
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DefaultPreDriverLaunchHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockPreLaunchHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/#review92063
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On July 16, 2015, 1:45 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36297/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 1:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-650
> https://issues.apache.org/jira/browse/LENS-650
>
>
> Repository: lens
>
>
> Description
> -------
>
> By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e87ed23429d3172db86c17e4ec5e37e2e903374b
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 67a4667d6443d5363f311dadfe30bb4e73ee4217
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78a08b29045f86e69f0180ab04f50705315
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java a6c97aeee50e730888c366d12b41c54d75eaf317
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java eab42d095ced23b9fd5b1fb854043d9668307883
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java b56c67ce6909a11b1cdec9f52427683f0b11dd41
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b52b08ad78a4c74c61376fb3c6bc6284f38b0de9
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 35112367b1b40309c04e6748f7ae69ceac959a28
> lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
> lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
> lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
> lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
>
> Diff: https://reviews.apache.org/r/36297/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.854s]
> [INFO] Lens .............................................. SUCCESS [2.786s]
> [INFO] Lens API .......................................... SUCCESS [19.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.773s]
> [INFO] Lens Cube ......................................... SUCCESS [4:12.475s]
> [INFO] Lens DB storage ................................... SUCCESS [18.426s]
> [INFO] Lens Query Library ................................ SUCCESS [13.940s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:45.497s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.123s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.222s]
> [INFO] Lens client ....................................... SUCCESS [34.486s]
> [INFO] Lens CLI .......................................... SUCCESS [2:34.816s]
> [INFO] Lens Examples ..................................... SUCCESS [8.202s]
> [INFO] Lens Distribution ................................. SUCCESS [8.005s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.986s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.963s]
> [INFO] Lens Regression ................................... SUCCESS [11.062s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.384s
> [INFO] Finished at: Thu Jul 16 13:41:39 UTC 2015
> [INFO] Final Memory: 181M/1709M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 17, 2015, 3:02 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, lines 320-322
> > <https://reviews.apache.org/r/36297/diff/5/?file=1013395#file1013395line320>
> >
> > Why is this change required wrt driverEventListener registered only with HiveDriver ?
Just reverting the changes done here: https://github.com/apache/incubator-lens/commit/2e5748a8c5dcff9627b8d125820371f1d4667d61#diff-c13b4332c4498a2dc1991bba947b4d6eL318
the registration of this particular instance named `driverEventListener` is only to be done for hive driver, here's the code:
```
final LensEventListener<DriverEvent> driverEventListener = new LensEventListener<DriverEvent>() {
@Override
public void onEvent(DriverEvent event) {
// Need to restore session only in case of hive driver
if (event instanceof DriverSessionStarted) {
log.info("New driver event by driver " + event.getDriver());
handleDriverSessionStart(event);
}
}
};
```
Could probably rename the variable to convey this.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/#review92053
-----------------------------------------------------------
On July 16, 2015, 7:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36297/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 7:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-650
> https://issues.apache.org/jira/browse/LENS-650
>
>
> Repository: lens
>
>
> Description
> -------
>
> By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e87ed23429d3172db86c17e4ec5e37e2e903374b
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 67a4667d6443d5363f311dadfe30bb4e73ee4217
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78a08b29045f86e69f0180ab04f50705315
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java a6c97aeee50e730888c366d12b41c54d75eaf317
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java eab42d095ced23b9fd5b1fb854043d9668307883
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java b56c67ce6909a11b1cdec9f52427683f0b11dd41
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b52b08ad78a4c74c61376fb3c6bc6284f38b0de9
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 35112367b1b40309c04e6748f7ae69ceac959a28
> lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
> lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
> lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
> lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
>
> Diff: https://reviews.apache.org/r/36297/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.854s]
> [INFO] Lens .............................................. SUCCESS [2.786s]
> [INFO] Lens API .......................................... SUCCESS [19.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.773s]
> [INFO] Lens Cube ......................................... SUCCESS [4:12.475s]
> [INFO] Lens DB storage ................................... SUCCESS [18.426s]
> [INFO] Lens Query Library ................................ SUCCESS [13.940s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:45.497s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.123s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.222s]
> [INFO] Lens client ....................................... SUCCESS [34.486s]
> [INFO] Lens CLI .......................................... SUCCESS [2:34.816s]
> [INFO] Lens Examples ..................................... SUCCESS [8.202s]
> [INFO] Lens Distribution ................................. SUCCESS [8.005s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.986s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.963s]
> [INFO] Lens Regression ................................... SUCCESS [11.062s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.384s
> [INFO] Finished at: Thu Jul 16 13:41:39 UTC 2015
> [INFO] Final Memory: 181M/1709M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/#review92053
-----------------------------------------------------------
Other changes look good.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (lines 317 - 319)
<https://reviews.apache.org/r/36297/#comment145954>
Why is this change required wrt driverEventListener registered only with HiveDriver ?
- Amareshwari Sriramadasu
On July 16, 2015, 1:45 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36297/
> -----------------------------------------------------------
>
> (Updated July 16, 2015, 1:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-650
> https://issues.apache.org/jira/browse/LENS-650
>
>
> Repository: lens
>
>
> Description
> -------
>
> By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e87ed23429d3172db86c17e4ec5e37e2e903374b
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 67a4667d6443d5363f311dadfe30bb4e73ee4217
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78a08b29045f86e69f0180ab04f50705315
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java a6c97aeee50e730888c366d12b41c54d75eaf317
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java eab42d095ced23b9fd5b1fb854043d9668307883
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java b56c67ce6909a11b1cdec9f52427683f0b11dd41
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b52b08ad78a4c74c61376fb3c6bc6284f38b0de9
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 35112367b1b40309c04e6748f7ae69ceac959a28
> lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
> lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
> lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
> lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
>
> Diff: https://reviews.apache.org/r/36297/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.854s]
> [INFO] Lens .............................................. SUCCESS [2.786s]
> [INFO] Lens API .......................................... SUCCESS [19.928s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.773s]
> [INFO] Lens Cube ......................................... SUCCESS [4:12.475s]
> [INFO] Lens DB storage ................................... SUCCESS [18.426s]
> [INFO] Lens Query Library ................................ SUCCESS [13.940s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:45.497s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.123s]
> [INFO] Lens Server ....................................... SUCCESS [5:36.222s]
> [INFO] Lens client ....................................... SUCCESS [34.486s]
> [INFO] Lens CLI .......................................... SUCCESS [2:34.816s]
> [INFO] Lens Examples ..................................... SUCCESS [8.202s]
> [INFO] Lens Distribution ................................. SUCCESS [8.005s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:18.986s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.963s]
> [INFO] Lens Regression ................................... SUCCESS [11.062s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:22.384s
> [INFO] Finished at: Thu Jul 16 13:41:39 UTC 2015
> [INFO] Final Memory: 181M/1709M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
(Updated July 16, 2015, 7:15 p.m.)
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e87ed23429d3172db86c17e4ec5e37e2e903374b
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 67a4667d6443d5363f311dadfe30bb4e73ee4217
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78a08b29045f86e69f0180ab04f50705315
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java a6c97aeee50e730888c366d12b41c54d75eaf317
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java eab42d095ced23b9fd5b1fb854043d9668307883
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java b56c67ce6909a11b1cdec9f52427683f0b11dd41
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b52b08ad78a4c74c61376fb3c6bc6284f38b0de9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 35112367b1b40309c04e6748f7ae69ceac959a28
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.854s]
[INFO] Lens .............................................. SUCCESS [2.786s]
[INFO] Lens API .......................................... SUCCESS [19.928s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.773s]
[INFO] Lens Cube ......................................... SUCCESS [4:12.475s]
[INFO] Lens DB storage ................................... SUCCESS [18.426s]
[INFO] Lens Query Library ................................ SUCCESS [13.940s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:45.497s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.123s]
[INFO] Lens Server ....................................... SUCCESS [5:36.222s]
[INFO] Lens client ....................................... SUCCESS [34.486s]
[INFO] Lens CLI .......................................... SUCCESS [2:34.816s]
[INFO] Lens Examples ..................................... SUCCESS [8.202s]
[INFO] Lens Distribution ................................. SUCCESS [8.005s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.986s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.963s]
[INFO] Lens Regression ................................... SUCCESS [11.062s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.384s
[INFO] Finished at: Thu Jul 16 13:41:39 UTC 2015
[INFO] Final Memory: 181M/1709M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
(Updated July 16, 2015, 7:12 p.m.)
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e87ed23429d3172db86c17e4ec5e37e2e903374b
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 67a4667d6443d5363f311dadfe30bb4e73ee4217
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java e048a78a08b29045f86e69f0180ab04f50705315
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java a6c97aeee50e730888c366d12b41c54d75eaf317
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java eab42d095ced23b9fd5b1fb854043d9668307883
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java b56c67ce6909a11b1cdec9f52427683f0b11dd41
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java b52b08ad78a4c74c61376fb3c6bc6284f38b0de9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 35112367b1b40309c04e6748f7ae69ceac959a28
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.854s]
[INFO] Lens .............................................. SUCCESS [2.786s]
[INFO] Lens API .......................................... SUCCESS [19.928s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.773s]
[INFO] Lens Cube ......................................... SUCCESS [4:12.475s]
[INFO] Lens DB storage ................................... SUCCESS [18.426s]
[INFO] Lens Query Library ................................ SUCCESS [13.940s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:45.497s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.123s]
[INFO] Lens Server ....................................... SUCCESS [5:36.222s]
[INFO] Lens client ....................................... SUCCESS [34.486s]
[INFO] Lens CLI .......................................... SUCCESS [2:34.816s]
[INFO] Lens Examples ..................................... SUCCESS [8.202s]
[INFO] Lens Distribution ................................. SUCCESS [8.005s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.986s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.963s]
[INFO] Lens Regression ................................... SUCCESS [11.062s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.384s
[INFO] Finished at: Thu Jul 16 13:41:39 UTC 2015
[INFO] Final Memory: 181M/1709M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 14, 2015, 4:17 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java, line 26
> > <https://reviews.apache.org/r/36297/diff/3/?file=1002182#file1002182line26>
> >
> > Please add javadoc for interface and the methods.
> >
> > Interface name as PreDriverLaunchHook with method preLaunch() seems too much of preLaunch.
> >
> > Shall we name interface as QueryHook? And call method preSubmit() ?
> >
> > And more hooks can be added here later if required.
to me, between submit and launch, launch is closer to the underlying operation. Submit somehow feels like a command issued. launch is in between the execution of a command. And the hook is supposed to be just that. Hence the name.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/#review91601
-----------------------------------------------------------
On July 8, 2015, 4:50 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36297/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 4:50 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-650
> https://issues.apache.org/jira/browse/LENS-650
>
>
> Repository: lens
>
>
> Description
> -------
>
> By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java ad27d78e1839fa60df8f2429901b77221be71653
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DefaultPreDriverLaunchHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockPreLaunchHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691
> lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
> lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
> lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
> lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
>
> Diff: https://reviews.apache.org/r/36297/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.874s]
> [INFO] Lens .............................................. SUCCESS [2.753s]
> [INFO] Lens API .......................................... SUCCESS [18.422s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.265s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.248s]
> [INFO] Lens DB storage ................................... SUCCESS [39.612s]
> [INFO] Lens Query Library ................................ SUCCESS [37.755s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:03.308s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.056s]
> [INFO] Lens Server ....................................... SUCCESS [5:30.772s]
> [INFO] Lens client ....................................... SUCCESS [39.233s]
> [INFO] Lens CLI .......................................... SUCCESS [2:48.013s]
> [INFO] Lens Examples ..................................... SUCCESS [9.927s]
> [INFO] Lens Distribution ................................. SUCCESS [8.531s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:28.750s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.839s]
> [INFO] Lens Regression ................................... SUCCESS [12.545s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:50.747s
> [INFO] Finished at: Wed Jul 08 11:19:26 UTC 2015
> [INFO] Final Memory: 187M/1793M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/#review91601
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java (line 26)
<https://reviews.apache.org/r/36297/#comment145084>
Please add javadoc for interface and the methods.
Interface name as PreDriverLaunchHook with method preLaunch() seems too much of preLaunch.
Shall we name interface as QueryHook? And call method preSubmit() ?
And more hooks can be added here later if required.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 313)
<https://reviews.apache.org/r/36297/#comment145085>
Just a thought here -
Can this be different for each driver? Then the initialization would happen on driver - reading driver conf.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 314)
<https://reviews.apache.org/r/36297/#comment145086>
Can we create it outside of forloop and pass register with drivers?
- Amareshwari Sriramadasu
On July 8, 2015, 11:20 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36297/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 11:20 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-650
> https://issues.apache.org/jira/browse/LENS-650
>
>
> Repository: lens
>
>
> Description
> -------
>
> By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java ad27d78e1839fa60df8f2429901b77221be71653
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DefaultPreDriverLaunchHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockPreLaunchHook.java PRE-CREATION
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691
> lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
> lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
> lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
> lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
>
> Diff: https://reviews.apache.org/r/36297/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.874s]
> [INFO] Lens .............................................. SUCCESS [2.753s]
> [INFO] Lens API .......................................... SUCCESS [18.422s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.265s]
> [INFO] Lens Cube ......................................... SUCCESS [4:13.248s]
> [INFO] Lens DB storage ................................... SUCCESS [39.612s]
> [INFO] Lens Query Library ................................ SUCCESS [37.755s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:03.308s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.056s]
> [INFO] Lens Server ....................................... SUCCESS [5:30.772s]
> [INFO] Lens client ....................................... SUCCESS [39.233s]
> [INFO] Lens CLI .......................................... SUCCESS [2:48.013s]
> [INFO] Lens Examples ..................................... SUCCESS [9.927s]
> [INFO] Lens Distribution ................................. SUCCESS [8.531s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:28.750s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.839s]
> [INFO] Lens Regression ................................... SUCCESS [12.545s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:50.747s
> [INFO] Finished at: Wed Jul 08 11:19:26 UTC 2015
> [INFO] Final Memory: 187M/1793M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
(Updated July 8, 2015, 4:50 p.m.)
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java ad27d78e1839fa60df8f2429901b77221be71653
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DefaultPreDriverLaunchHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockPreLaunchHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.874s]
[INFO] Lens .............................................. SUCCESS [2.753s]
[INFO] Lens API .......................................... SUCCESS [18.422s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.265s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.248s]
[INFO] Lens DB storage ................................... SUCCESS [39.612s]
[INFO] Lens Query Library ................................ SUCCESS [37.755s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:03.308s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.056s]
[INFO] Lens Server ....................................... SUCCESS [5:30.772s]
[INFO] Lens client ....................................... SUCCESS [39.233s]
[INFO] Lens CLI .......................................... SUCCESS [2:48.013s]
[INFO] Lens Examples ..................................... SUCCESS [9.927s]
[INFO] Lens Distribution ................................. SUCCESS [8.531s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:28.750s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.839s]
[INFO] Lens Regression ................................... SUCCESS [12.545s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:50.747s
[INFO] Finished at: Wed Jul 08 11:19:26 UTC 2015
[INFO] Final Memory: 187M/1793M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 36297: LENS-650: Move pre-submit hook out of User
Config Loader
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
(Updated July 8, 2015, 4:22 p.m.)
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user config loader. The code was made a part of user config loader because the need originated as a gap in user config loader. But the solution could have been separate. Creating this jira to address this issue.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java b7a3be72352cba201f7244822c08e59f298fc64c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8355f29df831fad25348b51bd22b0cc45c968f76
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bda6572adfcc4834197608fa43f68dbaabb2d852
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java be34164dd49b734b94fc2c121130613555402d50
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java ad27d78e1839fa60df8f2429901b77221be71653
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DefaultPreDriverLaunchHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java 93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockPreLaunchHook.java PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 429b26283afbd15a357b1529c2ca6767cca83691
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java 5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java 009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java 0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing
-------
Thanks,
Rajat Khandelwal