You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "HBase QA (JIRA)" <ji...@apache.org> on 2019/05/24 03:50:00 UTC
[jira] [Commented] (HBASE-22467) WebUI changes to enable Apache
Knox UI proxying
[ https://issues.apache.org/jira/browse/HBASE-22467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847213#comment-16847213 ]
HBase QA commented on HBASE-22467:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange} 0m 0s{color} | {color:orange} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 37s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 29s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} hbase-http: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 24s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 34s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 41s{color} | {color:red} hbase-http generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 0s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}132m 39s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 55s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}184m 54s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-http |
| | HTTP parameter directly written to HTTP header output in org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest, HttpServletResponse) At ProfileOutputServlet.java:HTTP header output in org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest, HttpServletResponse) At ProfileOutputServlet.java:[line 59] |
| | HTTP parameter written to Servlet output in org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest, HttpServletResponse) At ProfileOutputServlet.java:output in org.apache.hadoop.hbase.http.ProfileOutputServlet.doGet(HttpServletRequest, HttpServletResponse) At ProfileOutputServlet.java:[line 60] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/PreCommit-HBASE-Build/407/artifact/patchprocess/Dockerfile |
| JIRA Issue | HBASE-22467 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12969567/HBASE-22467.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux d683a99081c9 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6b899ccbbc |
| maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/407/artifact/patchprocess/diff-checkstyle-hbase-http.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/407/artifact/patchprocess/new-findbugs-hbase-http.html |
| Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/407/testReport/ |
| Max. process+thread count | 4520 (vs. ulimit of 10000) |
| modules | C: hbase-http hbase-server U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/407/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> WebUI changes to enable Apache Knox UI proxying
> -----------------------------------------------
>
> Key: HBASE-22467
> URL: https://issues.apache.org/jira/browse/HBASE-22467
> Project: HBase
> Issue Type: Improvement
> Components: UI
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Attachments: HBASE-22467.001.patch
>
>
> Apache Knox's gateway is nice in that it can provide centralized authentication and authorization for a collection of service. Additionally, it can expose "private" nodes through a single point (e.g. a gateway). This makes our life as developers much easier in cloud deployments where it's not straightforward to access nodes (e.g. they're running on some private network).
> KNOX-1866 captures the changes over there required to make HBase's proxying actually work (definition lives there), but there were a few things we do in our UI which made it hard/impossible to proxy it correctly.
> * ProfilerServlet was dropping extra query parameters in the URL
> * JSON task output on master/regionserver couldn't be disambiguated
> * Some missing /master-status and /rs-status links couldn't be disambiguated properly due to a lack of context
> * Missing content-type set on a profiler servlet response
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)