You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/08 15:04:18 UTC

[GitHub] [superset] D3nn3 opened a new issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

D3nn3 opened a new issue #15586:
URL: https://github.com/apache/superset/issues/15586

1. `0` as input for min `Y AXIS BOUNDS` in `Multiple Line Charts` gets ignored, everything else works though (e.g. 5, 1000, -5).
2. Selecting `Y BOUNDS` does nothing.

Didn't find any open issues regarding this. If I missed it and this is a duplicate please disregard and close the issue.

### Expected results

1. With `0` as input in min `Y AXIS BOUNDS` the Y axis in the visualization should start at 0.
2. With `Y BOUNDS` deselected the min and max value shouldn't necessarily be displayed.

### Actual results

1. `0` as input gets completely ignored and has the same effect as leaving `Min` empty.
2. No matter of selected or not, min and max values always get displayed, no matter the values entered.

### Environment

- browser: Firefox 89.0.2 on Ubuntu
- superset version: `apache/superset:1.2.0`

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] stephenLYZ edited a comment on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

stephenLYZ edited a comment on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-877584295


   Hi @D3nn3  It seems that https://github.com/apache/superset/issues/14998 is very similar to what you mentioned, please let us know if it can meet your needs. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

junlincc commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-879250891


   @D3nn3 you are welcome to take the ownership and contribute codes to Multiple Line Charts or any legacy charts, as we are actively maintaining the alternatives which are more extensible. we will provide support and review to your solution. 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] D3nn3 edited a comment on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

D3nn3 edited a comment on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-876982158

Hi @junlincc , thanks for getting back to me so quickly. Unfortunately the Mixed Timeseries Chart doesn't offer the functionality needed.

The current use case is simple but somehow unsolvable it seems 😅 We want to a chart displaying the number of X and additionally the moving average. We did this creating two different line charts and combining these in a Multiple Line Charts visualization.

Alternatives that don't seem to work:
- Mixed Timeseries Chart doesn't allow advanced analytics.
- Using a line chart as annotation layer in different visualizations also doesn't work because the `chart` drop down is always empty when selecting `time series` as annotation layer type and `line chart` as annotation source. Not sure if it is a bug or not yet.

I feel like this should easily be possible and I'm missing something... What's the alternative for doing this if `Multiple Line Charts` is deprecated?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] D3nn3 commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

D3nn3 commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-876982158

Hi @junlincc , thanks for getting back to me so quickly. Unfortunately the Mixed Timeseries Chart doesn't offer the functionality needed.

I feel like this should easily be possible and I'm missing something...

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] stephenLYZ commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

stephenLYZ commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-877584295


   Hi @D3nn3  It seems that https://github.com/apache/superset/issues/14998 is very similar to what you mentioned, see if it can meet your needs. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] D3nn3 edited a comment on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

D3nn3 edited a comment on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-893382636

Hey @villebro, thanks for getting back to me.

Adding Advanced Analytics to Mixed Time Series Chart would solve it (only if it can be applied to a single query, e.g. only Query A, and not necessarily to both at the same time).

Another (maybe "better" and more flexible) solution would be the following:
- Add Advanced Analytics to Time Series Chart (afaik this has been done or is planned? v1.2.0 doesn't have this though)
- Fix Time Series Annotation Layers. Currently filters applied in a Dashboard regarding time range don't properly propagate.

This would allow us to mix two (and more!) Time Series charts (with optional & individual advanced analytics) or one/multiple Time Series charts and a Mixed Time Series chart (always via Annotation Layers) where e.g. you have a raw count metric and additionally the rolling window in one chart. I think this solution is more flexible and also allows combining more than two different charts (which would be the limitation of just adding Advanced Analytics to Mixed Time Series Charts) as already mentioned before.

Adding Advanced Analytics to Mixed Time Series Charts would allow an additional use cases that my proposed solution wouldn't though. As soon as you want to have Advanced Analytics in a Bar visualization there doesn't seem a way to realize this. But I think this isn't a typical use case (at least my team never had the urge to do something like this) and could be added in a later release (e.g. v1.4.0 or even later, depending on available resources).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] junlincc commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

junlincc commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-877513849


   Hi @D3nn3 We will make sure reaching feature parity before deprecating it, so don't worry. We need to allocate resource right in order to have one solid combination chart that support multiple y-aixs, and we decided Mix Times-series is the one. 
   
   > * Mixed Timeseries Chart doesn't allow advanced analytics.
   It's in progress. 
   @zhaoyongjie let's push your PR forward and see if @xiezhongfu and @stephenLYZ can use your code for the Mixed chart. 
   
   > * Using a line chart as annotation layer in different visualizations
   Likely a bug, we will look into it. @villebro 
   
   In short, we will have both annotation and AA work in the new Mixed chart.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

villebro commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-892599484


   We should be able to introduce Advanced Analytics into Mixed Timeseries Chart not that it has been added to the new Timeseries chart. Would that solve your problem @D3nn3 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] D3nn3 commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

D3nn3 commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-893382636

Adding Advanced Analytics to Mixed Time Series Chart would solve it (only if it can be applied to a single query, e.g. only Query A, and not necessarily to both at the same time).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] junlincc commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

junlincc commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-876598132


   @D3nn3 hi! thanks for reporting. unfortunately Multi-line chart is not being actively being maintained. We offer Mix Time-series chart as alternative which should support Y axis bound. Please let us know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] D3nn3 commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

D3nn3 commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-878014167


   It seems that the fix was for line charts. I checked and line charts work fine but my problem is with the visualization type "**Multiple** Line Charts".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on issue #15586: Y Axis Bounds in Multiple Line Charts not working as intended

Posted by GitBox <gi...@apache.org>.

villebro commented on issue #15586:
URL: https://github.com/apache/superset/issues/15586#issuecomment-892599484


   We should be able to introduce Advanced Analytics into Mixed Timeseries Chart not that it has been added to the new Timeseries chart. Would that solve your problem @D3nn3 ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org