[GitHub] [accumulo] Codegass edited a comment on pull request #2553: Refactor testGetByPrefix() test case to improve readability

[GitBox <gi...@apache.org>]

Codegass edited a comment on pull request #2553:
URL: https://github.com/apache/accumulo/pull/2553#issuecomment-1062471775


   > The benefit to these changes is not clear. It's a large change with very little benefit. The motivation seems highly subjective.
   
   @ctubbsii Thanks for the reply!
   
   The motivation is to simplify this complicated test case and improve the readability for each test scenario. The original case is close to 100 lines of code. After refactoring, each new test case that split from the original case is simple and has a coherent goal. Each case has only about 15 lines of code and describes the test purpose in their test name.
   
   In addition, each test case now will only fail due to one reason, the original test case could fail due to 10 reasons. When using this in the CI\CD check, debug will be more straightforward. (Don't need to run the CI multiple times to locate every defect.)
   
   This refactor splitting the test case is a time one effort, but it may benefit in the long term for the maintenance. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org