You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2012/04/30 20:34:33 UTC

Re: svn commit: r1332324 - /jmeter/trunk/bin/saveservice.properties

On 30 April 2012 19:21,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Mon Apr 30 18:21:01 2012
> New Revision: 1332324
>
> URL: http://svn.apache.org/viewvc?rev=1332324&view=rev
> Log:
> Bug 53164 - New System Sampler
> Save Service
>
> Modified:
>    jmeter/trunk/bin/saveservice.properties

The _version property also needs to be updated please.

It could be postponed until just before the next release, but it might
get forgotten.
It does not matter if the version is changed again before the next
release, but it does matter if we forget to change it (as has
unfortunately happened before).

> Modified: jmeter/trunk/bin/saveservice.properties
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/saveservice.properties?rev=1332324&r1=1332323&r2=1332324&view=diff
> ==============================================================================
> --- jmeter/trunk/bin/saveservice.properties (original)
> +++ jmeter/trunk/bin/saveservice.properties Mon Apr 30 18:21:01 2012
> @@ -265,6 +265,8 @@ SummaryReport=org.apache.jmeter.visualiz
>  SwitchController=org.apache.jmeter.control.SwitchController
>  SwitchControllerGui=org.apache.jmeter.control.gui.SwitchControllerGui
>  SyncTimer=org.apache.jmeter.timers.SyncTimer
> +SystemSampler=org.apache.jmeter.protocol.system.SystemSampler
> +SystemSamplerGui=org.apache.jmeter.protocol.system.gui.SystemSamplerGui
>  Table=org.apache.jmeter.testelement.Table
>  TableGui=org.apache.jmeter.report.gui.TableGui
>  TableVisualizer=org.apache.jmeter.visualizers.TableVisualizer
>
>

Re: svn commit: r1332324 - /jmeter/trunk/bin/saveservice.properties

Posted by sebb <se...@gmail.com>.
On 30 April 2012 19:37, Philippe Mouawad <ph...@gmail.com> wrote:
> Ok I did it,
> What's the exact rule for changing it ?

As the comment says:

# Must be updated if the file has been changed since the previous release

I did wonder about using the SVN revision number, but that would
change even for comment fixes.

>
> Thanks
> Regards
> Philippe
>
> On Mon, Apr 30, 2012 at 8:34 PM, sebb <se...@gmail.com> wrote:
>
>> On 30 April 2012 19:21,  <pm...@apache.org> wrote:
>> > Author: pmouawad
>> > Date: Mon Apr 30 18:21:01 2012
>> > New Revision: 1332324
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1332324&view=rev
>> > Log:
>> > Bug 53164 - New System Sampler
>> > Save Service
>> >
>> > Modified:
>> >    jmeter/trunk/bin/saveservice.properties
>>
>> The _version property also needs to be updated please.
>>
>> It could be postponed until just before the next release, but it might
>> get forgotten.
>> It does not matter if the version is changed again before the next
>> release, but it does matter if we forget to change it (as has
>> unfortunately happened before).
>>
>> > Modified: jmeter/trunk/bin/saveservice.properties
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/bin/saveservice.properties?rev=1332324&r1=1332323&r2=1332324&view=diff
>> >
>> ==============================================================================
>> > --- jmeter/trunk/bin/saveservice.properties (original)
>> > +++ jmeter/trunk/bin/saveservice.properties Mon Apr 30 18:21:01 2012
>> > @@ -265,6 +265,8 @@ SummaryReport=org.apache.jmeter.visualiz
>> >  SwitchController=org.apache.jmeter.control.SwitchController
>> >  SwitchControllerGui=org.apache.jmeter.control.gui.SwitchControllerGui
>> >  SyncTimer=org.apache.jmeter.timers.SyncTimer
>> > +SystemSampler=org.apache.jmeter.protocol.system.SystemSampler
>> > +SystemSamplerGui=org.apache.jmeter.protocol.system.gui.SystemSamplerGui
>> >  Table=org.apache.jmeter.testelement.Table
>> >  TableGui=org.apache.jmeter.report.gui.TableGui
>> >  TableVisualizer=org.apache.jmeter.visualizers.TableVisualizer
>> >
>> >
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

Re: svn commit: r1332324 - /jmeter/trunk/bin/saveservice.properties

Posted by Philippe Mouawad <ph...@gmail.com>.
Ok I did it,
What's the exact rule for changing it ?

Thanks
Regards
Philippe

On Mon, Apr 30, 2012 at 8:34 PM, sebb <se...@gmail.com> wrote:

> On 30 April 2012 19:21,  <pm...@apache.org> wrote:
> > Author: pmouawad
> > Date: Mon Apr 30 18:21:01 2012
> > New Revision: 1332324
> >
> > URL: http://svn.apache.org/viewvc?rev=1332324&view=rev
> > Log:
> > Bug 53164 - New System Sampler
> > Save Service
> >
> > Modified:
> >    jmeter/trunk/bin/saveservice.properties
>
> The _version property also needs to be updated please.
>
> It could be postponed until just before the next release, but it might
> get forgotten.
> It does not matter if the version is changed again before the next
> release, but it does matter if we forget to change it (as has
> unfortunately happened before).
>
> > Modified: jmeter/trunk/bin/saveservice.properties
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/bin/saveservice.properties?rev=1332324&r1=1332323&r2=1332324&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/bin/saveservice.properties (original)
> > +++ jmeter/trunk/bin/saveservice.properties Mon Apr 30 18:21:01 2012
> > @@ -265,6 +265,8 @@ SummaryReport=org.apache.jmeter.visualiz
> >  SwitchController=org.apache.jmeter.control.SwitchController
> >  SwitchControllerGui=org.apache.jmeter.control.gui.SwitchControllerGui
> >  SyncTimer=org.apache.jmeter.timers.SyncTimer
> > +SystemSampler=org.apache.jmeter.protocol.system.SystemSampler
> > +SystemSamplerGui=org.apache.jmeter.protocol.system.gui.SystemSamplerGui
> >  Table=org.apache.jmeter.testelement.Table
> >  TableGui=org.apache.jmeter.report.gui.TableGui
> >  TableVisualizer=org.apache.jmeter.visualizers.TableVisualizer
> >
> >
>



-- 
Cordialement.
Philippe Mouawad.