You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/03/05 23:49:00 UTC

[Impala-ASF-CR] Generate JUnitXML if a command run by CMake fails 

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12668


Change subject: Generate JUnitXML if a command run by CMake fails
......................................................................

Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it works on Centos 6.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/build_junitxml_wrapper.sh
3 files changed, 56 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12668

to look at the new patch set (#7).

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself. It can be disabled by setting
DISABLE_CMAKE_JUNITXML.

The command output can include Unicode (e.g. smart quotes for
g++), so this also updates generate_junitxml.py to handle
Unicode.

The wrapper interacts poorly with add_custom_command/add_custom_target
CMake commands that use 'cd directory && do_something', so this
switches those locations (in /docker) to use CMake's WORKING_DIRECTORY.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it doesn't use the wrapper when DISABLE_CMAKE_JUNITXML
   is set.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
M docker/CMakeLists.txt
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
5 files changed, 105 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/7
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 6:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6393/


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Sep 2020 04:34:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 3: Code-Review+1

Rebased, carry +1


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 23:36:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2363/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 00:34:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6382/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 03:05:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Sep 2020 05:28:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6382/


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 08:12:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12668/2/bin/junitxml_command_wrapper.sh
File bin/junitxml_command_wrapper.sh:

http://gerrit.cloudera.org:8080/#/c/12668/2/bin/junitxml_command_wrapper.sh@20
PS2, Line 20: for a shell command
> Nit: redundant wording?
Good point, there are redundant words that are redundant. Fixed.



-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 23:36:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 10: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 10
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Oct 2020 04:58:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7069/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 01:59:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 8: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6427/


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2020 21:22:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 10:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6532/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 10
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:35:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2421/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 23:22:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12668

to look at the new patch set (#8).

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself. It can be disabled by setting
DISABLE_CMAKE_JUNITXML.

The command output can include Unicode (e.g. smart quotes for
g++), so this also updates generate_junitxml.py to handle
Unicode.

The wrapper interacts poorly with add_custom_command/add_custom_target
CMake commands that use 'cd directory && do_something', so this
switches those locations (in /docker) to use CMake's WORKING_DIRECTORY.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it doesn't use the wrapper when DISABLE_CMAKE_JUNITXML
   is set.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
M docker/CMakeLists.txt
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
5 files changed, 108 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/8
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself. It can be disabled by setting
DISABLE_CMAKE_JUNITXML.

The command output can include Unicode (e.g. smart quotes for
g++), so this also updates generate_junitxml.py to handle
Unicode.

The wrapper interacts poorly with add_custom_command/add_custom_target
CMake commands that use 'cd directory && do_something', so this
switches those locations (in /docker) to use CMake's WORKING_DIRECTORY.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it doesn't use the wrapper when DISABLE_CMAKE_JUNITXML
   is set.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Reviewed-on: http://gerrit.cloudera.org:8080/12668
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
M docker/CMakeLists.txt
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
5 files changed, 108 insertions(+), 18 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 11
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 4: Code-Review+1

Rebased, carry +1


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 23:21:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7392/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 10
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:53:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6400/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Sep 2020 00:20:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6393/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Sep 2020 23:22:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7165/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2020 17:44:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2020 05:26:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 9: Code-Review+1

Thanks for the enhancement, Joe. I especially enjoyed the bash redirection artwork :)
Carrying and agreeing with +1 from David; letting some other folks take a look.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 9
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2020 12:12:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12668

to look at the new patch set (#3).

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it works on Centos 6.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
3 files changed, 56 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 5: Code-Review+1

Reviving this. Rebased, carry +1


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 18:51:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12668

to look at the new patch set (#2).

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it works on Centos 6.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
3 files changed, 56 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12668

to look at the new patch set (#10).

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself. It can be disabled by setting
DISABLE_CMAKE_JUNITXML.

The command output can include Unicode (e.g. smart quotes for
g++), so this also updates generate_junitxml.py to handle
Unicode.

The wrapper interacts poorly with add_custom_command/add_custom_target
CMake commands that use 'cd directory && do_something', so this
switches those locations (in /docker) to use CMake's WORKING_DIRECTORY.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it doesn't use the wrapper when DISABLE_CMAKE_JUNITXML
   is set.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
M docker/CMakeLists.txt
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
5 files changed, 108 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/10
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 10
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 10: Code-Review+2

Rebased past the IMPALA-10016 change. Minor conflicts on docker/CMakeLists.txt. Carrying +2


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 10
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Oct 2020 23:35:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12668

to look at the new patch set (#6).

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................

IMPALA-8304: Generate JUnitXML if a command run by CMake fails

This wraps each command executed by CMake with a wrapper that
generates a JUnitXML file if the command fails. If the command
succeeds, the wrapper does nothing. The wrapper applies to C++
compilation, linking, and custom shell commands (such as
building the frontend via maven). It does not apply to failures
coming from CMake itself. It can be disabled by setting
DISABLE_CMAKE_JUNITXML.

Testing:
 - Verified it does not impact a successful build (including with
   ccache and/or distcc).
 - Verified it generates JUnitXML for C++ and Java compilation
   failures.
 - Verified it doesn't use the wrapper when DISABLE_CMAKE_JUNITXML
   is set.

Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
---
M CMakeLists.txt
M be/CMakeLists.txt
A bin/junitxml_command_wrapper.sh
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
4 files changed, 82 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/12668/6
-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6427/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 11 Sep 2020 17:28:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2449/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 23:58:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7095/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Sep 2020 00:34:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8304: Generate JUnitXML if a command run by CMake fails

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12668 )

Change subject: IMPALA-8304: Generate JUnitXML if a command run by CMake fails
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

Seems reasonable to me. I'd like someone else to have a look as well.

http://gerrit.cloudera.org:8080/#/c/12668/2/bin/junitxml_command_wrapper.sh
File bin/junitxml_command_wrapper.sh:

http://gerrit.cloudera.org:8080/#/c/12668/2/bin/junitxml_command_wrapper.sh@20
PS2, Line 20: for a shell command
Nit: redundant wording?



-- 
To view, visit http://gerrit.cloudera.org:8080/12668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If71f2faf3ab5052b56b38f1b291fee53c390ce23
Gerrit-Change-Number: 12668
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Mar 2019 21:47:07 +0000
Gerrit-HasComments: Yes