[isis] branch master updated: ISIS-2158: working on CI pipeline not failing issue

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 3827dc0  ISIS-2158: working on CI pipeline not failing issue
3827dc0 is described below

commit 3827dc063cf0a6a01fca190da037467e035db688
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri Feb 14 09:14:46 2020 +0100

    ISIS-2158: working on CI pipeline not failing issue
---
 .github/workflows/ci-build-core-no-push.yml |  4 +---
 .github/workflows/ci-build-site-no-push.yml |  2 +-
 scripts/ci/build-core.sh                    | 15 +++++++++------
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci-build-core-no-push.yml b/.github/workflows/ci-build-core-no-push.yml
index 593c830..78d23cf 100644
--- a/.github/workflows/ci-build-core-no-push.yml
+++ b/.github/workflows/ci-build-core-no-push.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       # to be shared among all steps of this job
-      BASELINE: 2.0.0-M2
+      BASELINE: 2.0.0-M3
       PROJECT_ROOT_PATH: ${{ github.workspace }}
       CI_SCRIPTS_PATH: ${{ github.workspace }}/scripts/ci
       
@@ -40,8 +40,6 @@ jobs:
     
     - name: Setup Script Environment
       shell: bash
-      # we write the more tricky varibles to the $SHARED_VARS_FILE using the full power of bash commands
-      # then we simply print all the (non-secret) variables as used by the build scripts to the console
       run: |
         echo ==============  ENV  =================
         echo BASELINE         \: $BASELINE
diff --git a/.github/workflows/ci-build-site-no-push.yml b/.github/workflows/ci-build-site-no-push.yml
index e10cf78..338baa4 100644
--- a/.github/workflows/ci-build-site-no-push.yml
+++ b/.github/workflows/ci-build-site-no-push.yml
@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       # to be shared among all steps of this job
-      BASELINE: 2.0.0-M2
+      BASELINE: 2.0.0-M3
       PROJECT_ROOT_PATH: ${{ github.workspace }}
       CI_SCRIPTS_PATH: ${{ github.workspace }}/scripts/ci
       ANTORA_PLAYBOOKS_PATH: ${{ github.workspace }}/antora/playbooks
diff --git a/scripts/ci/build-core.sh b/scripts/ci/build-core.sh
index 2b49c88..fd1550c 100644
--- a/scripts/ci/build-core.sh
+++ b/scripts/ci/build-core.sh
@@ -10,12 +10,6 @@ if [ -z "$PROJECT_ROOT_PATH" ]; then
   PROJECT_ROOT_PATH=`cd $SCRIPT_DIR/../.. ; pwd`
 fi
 
-#if [ -z "$REVISION" ]; then
-#  if [ ! -z "$SHARED_VARS_FILE" ] && [ -f "$SHARED_VARS_FILE" ]; then
-#    . $SHARED_VARS_FILE
-#    export $(cut -d= -f1 $SHARED_VARS_FILE)
-#  fi
-#fi
 if [ -z "$MVN_STAGES" ]; then
   MVN_STAGES="clean install"
 fi
@@ -81,6 +75,15 @@ mvn -s $SETTINGS_XML \
     | fgrep --line-buffered -v "[INFO] Using alternate deployment repository gcpappenginerepo" \
     | fgrep --line-buffered -v "[INFO] No site descriptor found: nothing to attach." \
     | fgrep --line-buffered -v "[INFO] Skipping because packaging 'jar' is not pom."
+	
+# debugging issue, where CI pipeline succeeds even though maven build fails
+if [ $? -eq 0 ]; then
+  echo "Maven ran ok"
+  exit 0
+else
+  echo "Maven failed" >&2
+  exit 1
+fi
 
 if [ ! -z "$REVISION" ]; then
   cd $PROJECT_ROOT_PATH/core-parent