You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/11 23:37:16 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #9267: [Charts] Use the Edit Properties modal throughout React views

codecov-io commented on issue #9267: [Charts] Use the Edit Properties modal throughout React views
URL: https://github.com/apache/incubator-superset/pull/9267#issuecomment-597932599
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=h1) Report
   > Merging [#9267](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c0f0d453778e282ab961f20298dcaf3f10788b30?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `35.59%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9267/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9267      +/-   ##
   ==========================================
   - Coverage    58.9%   58.88%   -0.02%     
   ==========================================
     Files         373      373              
     Lines       12026    12069      +43     
     Branches     2953     2957       +4     
   ==========================================
   + Hits         7084     7107      +23     
   - Misses       4763     4783      +20     
     Partials      179      179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tend/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9267/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIuanN4) | `65.3% <45.45%> (-5.75%)` | :arrow_down: |
   | [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9267/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.66% <50%> (-0.73%)` | :arrow_down: |
   | [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9267/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.9% <66.66%> (+0.17%)` | :arrow_up: |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9267/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `11.76% <7.69%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=footer). Last update [c0f0d45...3798a78](https://codecov.io/gh/apache/incubator-superset/pull/9267?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org