You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ji...@apache.org on 2017/04/17 23:58:25 UTC

[2/2] mesos git commit: Fixed the image signature check for Nexus Registry.

Fixed the image signature check for Nexus Registry.

Currently, the signature field of the docker v2 image manifest is
not used yet. The check of at least one image signature is too
strict because some registry (e.g., Nexus Registry) does not sign
the image manifest. We should release the signature check for now.

Review: https://reviews.apache.org/r/58479/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/643dafde
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/643dafde
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/643dafde

Branch: refs/heads/master
Commit: 643dafdec76bb176270fe686ec2400242ed0fe36
Parents: 265754f
Author: Gilbert Song <so...@gmail.com>
Authored: Tue Apr 18 07:57:30 2017 +0800
Committer: Jie Yu <yu...@gmail.com>
Committed: Tue Apr 18 07:57:30 2017 +0800

----------------------------------------------------------------------
 src/docker/spec.cpp | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/643dafde/src/docker/spec.cpp
----------------------------------------------------------------------
diff --git a/src/docker/spec.cpp b/src/docker/spec.cpp
index 88029c2..6b5588e 100644
--- a/src/docker/spec.cpp
+++ b/src/docker/spec.cpp
@@ -332,10 +332,6 @@ Option<Error> validate(const ImageManifest& manifest)
     return Error("'history' field size must be at least one");
   }
 
-  if (manifest.signatures_size() <= 0) {
-    return Error("'signatures' field size must be at least one");
-  }
-
   // Verify that blobSum and v1Compatibility numbers are equal.
   if (manifest.fslayers_size() != manifest.history_size()) {
     return Error("The size of 'fsLayers' should be equal "