[jira] [Commented] (HBASE-22936) Close memStoreScanners in StoreScanner#updateReaders else memory leak

["ramkrishna.s.vasudevan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917382#comment-16917382 ] 

ramkrishna.s.vasudevan commented on HBASE-22936:
------------------------------------------------

If any one needs to give a patch I can review it. If not I can prepare one. 
[~aoxiang], [~javaman_chen], [~chenyechao].

> Close memStoreScanners in StoreScanner#updateReaders else memory leak
> ---------------------------------------------------------------------
>
>                 Key: HBASE-22936
>                 URL: https://issues.apache.org/jira/browse/HBASE-22936
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Major
>             Fix For: 2.3.0, 2.1.7, 2.2.2
>
>
> Via [~aoxiang] from over on HBASE-22723
> {code}
> +      if (!closeLock.tryLock()) {
> +        // no lock acquired.
> +        LOG.debug("StoreScanner already has the close lokc. There is no need to updateReaders");
> +        return;
> +      }
> +      // lock acquired
> +      updateReaders = true;
> +      if (this.closing) {
> +        LOG.debug("StoreScanner already closing. There is no need to updateReaders");
> +        return;
> +      }
> {code}
> We need to close memStoreScanners in StoreScanner#updateReaders before this two return, someone else can take over the task.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)