[jira] [Comment Edited] (OAK-820) Add ContentSession#isLive()

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13657026#comment-13657026 ] 

angela edited comment on OAK-820 at 5/14/13 1:02 PM:
-----------------------------------------------------

well, Session#isLive is currently implemented with a hack as there is now way to determine if a
given content session has been closed -> see patch. which may not even work properly as the
content session could be closed without notifying the Session and leading to inconsistencies
as Session#isLive would return true.
 
similarly the user manager is defined to throw RepositoryException not IllegalStateException
such that i had to call any method on the Root that throws, catch the runtime exception an
rethrow which IMO is worse and infinitly ugly.
                
      was (Author: anchela):
    well, Session#isLive is currently implemented with a hack as there is now way to determine if a
given content session has been closed -> see patch. 
similarly the user manager is defined to throw RepositoryException not IllegalStateException
such that i had to call any method on the Root that throws, catch the runtime exception an
rethrow which IMO is worse and infinitly ugly.
                  
> Add ContentSession#isLive()
> ---------------------------
>
>                 Key: OAK-820
>                 URL: https://issues.apache.org/jira/browse/OAK-820
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: angela
>            Priority: Minor
>         Attachments: OAK-820.patch
>
>
> for consistency with ContentSession#close() and in order to be able to
> address a remaining TODO in the user manager implementation i would like
> to add ContentSession#isLive.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira