You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "spacewander (via GitHub)" <gi...@apache.org> on 2023/03/17 02:33:53 UTC

[GitHub] [apisix] spacewander commented on pull request #8358: refactor: refactor get last index func in log rotate plugin

spacewander commented on PR #8358:
URL: https://github.com/apache/apisix/pull/8358#issuecomment-1473027391

   > How do I write a test case for this? The original function is faulty, but the result happens to be fine @spacewander
   
   We can provide some fake access log to see if the function can filter out the right one from the wrong ones?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org