You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by chengjh <ch...@apache.org> on 2012/10/09 03:21:05 UTC
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
I have delivered the patch
https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff to
improve the graphic bullet interoperability with MS Word binary document.
Can any expert help the code review before I commit it?Thanks in advance.
[1]Call for Test::http://s.apache.org/YYk
On Fri, Sep 28, 2012 at 9:49 AM, chengjh <ch...@apache.org> wrote:
> Hi
>
> Graphic Bullet is a kind of bullet that is used in both MS Office and
> Apache OpenOffice.org. And it provides fancy graphics to replace the
> special characters as bullets and is used broadly. Unfortunately, till now,
> Apache OpenOffice.org Writer can not provide the fidelity with MS Word on
> the function area. So, I think it's time for us to do the graphic bullets
> fidelity improvement. And we will focus on it through this wiki
> http://s.apache.org/W8v. You are welcome to comment.Thanks.
>
> --
>
> Best Regards,Jianhong Cheng
>
>
--
Best Regards,Jianhong Cheng
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by chengjh <ch...@apache.org>.
Committed with 1414498.thanks for the code review.
On Thu, Nov 22, 2012 at 11:27 AM, chengjh <ch...@apache.org> wrote:
> Thanks to Fan's effort.
>
>
> On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng <zh...@gmail.com>wrote:
>
>> I will take a look at the patch. thx.
>>
>>
>>
>> 2012/11/21 Joost Andrae <Jo...@gmx.de>
>>
>> > Hi,
>> >
>> > maybe it helps if someone documents the usage of issue ids within the
>> > source code for unexperienced developers.
>> >
>> > In this example the issue represented by i120928 ( := OOo Issue Tracker
>> ID
>> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
>> > show_bug.cgi?id=120928<
>> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
>> >
>> > Am 21.11.2012 08:20, schrieb chengjh:
>> >
>> > Updated the patch according to the comments...Please review
>> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> >> action=diff.Thanks<
>> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
>> >> .
>> >>
>> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hd...@apache.org> wrote:
>> >>
>> >> I agree with Pedro that the change history belongs into the RCS,
>> >>> especially in a code base as ours where some source files have had
>> many
>> >>> hundreds of changes over their history of about twenty years.
>> >>>
>> >>> Of course an issue reference is valuable when the comment helps to
>> >>> understand what the code does and why it does it. Anything else is
>> >>> distracting.
>> >>>
>> >>
>> > Kind regards, Joost
>> >
>> >
>> >
>>
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
>
--
Best Regards,Jianhong Cheng
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by chengjh <ch...@apache.org>.
Committed with 1414498.thanks for the code review.
On Thu, Nov 22, 2012 at 11:27 AM, chengjh <ch...@apache.org> wrote:
> Thanks to Fan's effort.
>
>
> On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng <zh...@gmail.com>wrote:
>
>> I will take a look at the patch. thx.
>>
>>
>>
>> 2012/11/21 Joost Andrae <Jo...@gmx.de>
>>
>> > Hi,
>> >
>> > maybe it helps if someone documents the usage of issue ids within the
>> > source code for unexperienced developers.
>> >
>> > In this example the issue represented by i120928 ( := OOo Issue Tracker
>> ID
>> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
>> > show_bug.cgi?id=120928<
>> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
>> >
>> > Am 21.11.2012 08:20, schrieb chengjh:
>> >
>> > Updated the patch according to the comments...Please review
>> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> >> action=diff.Thanks<
>> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
>> >> .
>> >>
>> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hd...@apache.org> wrote:
>> >>
>> >> I agree with Pedro that the change history belongs into the RCS,
>> >>> especially in a code base as ours where some source files have had
>> many
>> >>> hundreds of changes over their history of about twenty years.
>> >>>
>> >>> Of course an issue reference is valuable when the comment helps to
>> >>> understand what the code does and why it does it. Anything else is
>> >>> distracting.
>> >>>
>> >>
>> > Kind regards, Joost
>> >
>> >
>> >
>>
>
>
>
> --
>
> Best Regards,Jianhong Cheng
>
>
--
Best Regards,Jianhong Cheng
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by chengjh <ch...@apache.org>.
Thanks to Fan's effort.
On Thu, Nov 22, 2012 at 11:02 AM, Fan Zheng <zh...@gmail.com> wrote:
> I will take a look at the patch. thx.
>
>
>
> 2012/11/21 Joost Andrae <Jo...@gmx.de>
>
> > Hi,
> >
> > maybe it helps if someone documents the usage of issue ids within the
> > source code for unexperienced developers.
> >
> > In this example the issue represented by i120928 ( := OOo Issue Tracker
> ID
> > 120928 ) is to be resolved to https://issues.apache.org/ooo/**
> > show_bug.cgi?id=120928<
> https://issues.apache.org/ooo/show_bug.cgi?id=120928>
> >
> > Am 21.11.2012 08:20, schrieb chengjh:
> >
> > Updated the patch according to the comments...Please review
> >> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
> >> action=diff.Thanks<
> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
> >> .
> >>
> >> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hd...@apache.org> wrote:
> >>
> >> I agree with Pedro that the change history belongs into the RCS,
> >>> especially in a code base as ours where some source files have had many
> >>> hundreds of changes over their history of about twenty years.
> >>>
> >>> Of course an issue reference is valuable when the comment helps to
> >>> understand what the code does and why it does it. Anything else is
> >>> distracting.
> >>>
> >>
> > Kind regards, Joost
> >
> >
> >
>
--
Best Regards,Jianhong Cheng
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by Fan Zheng <zh...@gmail.com>.
I will take a look at the patch. thx.
2012/11/21 Joost Andrae <Jo...@gmx.de>
> Hi,
>
> maybe it helps if someone documents the usage of issue ids within the
> source code for unexperienced developers.
>
> In this example the issue represented by i120928 ( := OOo Issue Tracker ID
> 120928 ) is to be resolved to https://issues.apache.org/ooo/**
> show_bug.cgi?id=120928<https://issues.apache.org/ooo/show_bug.cgi?id=120928>
>
> Am 21.11.2012 08:20, schrieb chengjh:
>
> Updated the patch according to the comments...Please review
>> https://issues.apache.org/ooo/**attachment.cgi?id=79931&**
>> action=diff.Thanks<https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks>
>> .
>>
>> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hd...@apache.org> wrote:
>>
>> I agree with Pedro that the change history belongs into the RCS,
>>> especially in a code base as ours where some source files have had many
>>> hundreds of changes over their history of about twenty years.
>>>
>>> Of course an issue reference is valuable when the comment helps to
>>> understand what the code does and why it does it. Anything else is
>>> distracting.
>>>
>>
> Kind regards, Joost
>
>
>
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by Joost Andrae <Jo...@gmx.de>.
Hi,
maybe it helps if someone documents the usage of issue ids within the
source code for unexperienced developers.
In this example the issue represented by i120928 ( := OOo Issue Tracker
ID 120928 ) is to be resolved to
https://issues.apache.org/ooo/show_bug.cgi?id=120928
Am 21.11.2012 08:20, schrieb chengjh:
> Updated the patch according to the comments...Please review
> https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks.
>
> On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hd...@apache.org> wrote:
>
>> I agree with Pedro that the change history belongs into the RCS,
>> especially in a code base as ours where some source files have had many
>> hundreds of changes over their history of about twenty years.
>>
>> Of course an issue reference is valuable when the comment helps to
>> understand what the code does and why it does it. Anything else is
>> distracting.
Kind regards, Joost
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by chengjh <ch...@apache.org>.
Updated the patch according to the comments...Please review
https://issues.apache.org/ooo/attachment.cgi?id=79931&action=diff.Thanks.
On Tue, Oct 9, 2012 at 3:17 PM, Herbert Dürr <hd...@apache.org> wrote:
> I agree with Pedro that the change history belongs into the RCS,
> especially in a code base as ours where some source files have had many
> hundreds of changes over their history of about twenty years.
>
> Of course an issue reference is valuable when the comment helps to
> understand what the code does and why it does it. Anything else is
> distracting.
>
> Herbert
> (sorry for top-posting)
>
>
> On 2012/10/09 8:06 AM, chengjh wrote:
>
>> The comment format can provide another way to get the whole code change
>> set,except svn, which is valuable for someone who has only the code
>> base,is
>> not familiar with the tool svn, especially,meets regression issue related
>> to the code change.The comments will be quite helpful.
>>
>> On Tue, Oct 9, 2012 at 12:04 PM, Pedro Giffuni<pf...@apache.org> wrote:
>>
>> Hello;
>>>
>>> --- Lun 8/10/12, chengjh ha scritto:
>>>
>>>
>>> Data: Lunedě 8 ottobre 2012, 20:21
>>>>
>>>> I have delivered the patch
>>>> https://issues.apache.org/ooo/**attachment.cgi?id=79748&**action=diff<https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff>
>>>> to
>>>> improve the graphic bullet interoperability with MS Word
>>>> binary document.
>>>> Can any expert help the code review before I commit
>>>> it?Thanks in advance.
>>>>
>>>> [1]Call for Test::http://s.apache.org/YYk
>>>>
>>>>
>>>
>>> Please avoid comments like
>>> //begin fix for ixxxxxx
>>> ...
>>> //end of fix
>>>
>>> Such comments are useless and if someone does care that type of
>>> information is registered by the version control system (SVN) anyways.
>>>
>>> Pedro.
>>>
>>
--
Best Regards,Jianhong Cheng
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by Herbert Dürr <hd...@apache.org>.
I agree with Pedro that the change history belongs into the RCS,
especially in a code base as ours where some source files have had many
hundreds of changes over their history of about twenty years.
Of course an issue reference is valuable when the comment helps to
understand what the code does and why it does it. Anything else is
distracting.
Herbert
(sorry for top-posting)
On 2012/10/09 8:06 AM, chengjh wrote:
> The comment format can provide another way to get the whole code change
> set,except svn, which is valuable for someone who has only the code base,is
> not familiar with the tool svn, especially,meets regression issue related
> to the code change.The comments will be quite helpful.
>
> On Tue, Oct 9, 2012 at 12:04 PM, Pedro Giffuni<pf...@apache.org> wrote:
>
>> Hello;
>>
>> --- Lun 8/10/12, chengjh ha scritto:
>>
>>
>>> Data: Lunedì 8 ottobre 2012, 20:21
>>> I have delivered the patch
>>> https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff
>>> to
>>> improve the graphic bullet interoperability with MS Word
>>> binary document.
>>> Can any expert help the code review before I commit
>>> it?Thanks in advance.
>>>
>>> [1]Call for Test::http://s.apache.org/YYk
>>>
>>
>>
>> Please avoid comments like
>> //begin fix for ixxxxxx
>> ...
>> //end of fix
>>
>> Such comments are useless and if someone does care that type of
>> information is registered by the version control system (SVN) anyways.
>>
>> Pedro.
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by Jürgen Schmidt <jo...@gmail.com>.
On 10/9/12 8:06 AM, chengjh wrote:
> The comment format can provide another way to get the whole code change
> set,except svn, which is valuable for someone who has only the code base,is
> not familiar with the tool svn, especially,meets regression issue related
> to the code change.The comments will be quite helpful.
I agree to Pedro that we don't use such comments in our code and we
shouldn't do that. We should probably cleanup the code form existing
comments like this.
The information is available via the SCM system and that is enough.
Comments of general purpose to explain what the code is doing or to give
some further explanation of the logic behind it is quite useful and good.
But this kind of comments are not really useful and make the code more
unreadable and doesn't really help.
Juergen
>
> On Tue, Oct 9, 2012 at 12:04 PM, Pedro Giffuni <pf...@apache.org> wrote:
>
>> Hello;
>>
>> --- Lun 8/10/12, chengjh ha scritto:
>>
>>
>>> Data: Lunedì 8 ottobre 2012, 20:21
>>> I have delivered the patch
>>> https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff
>>> to
>>> improve the graphic bullet interoperability with MS Word
>>> binary document.
>>> Can any expert help the code review before I commit
>>> it?Thanks in advance.
>>>
>>> [1]Call for Test::http://s.apache.org/YYk
>>>
>>
>>
>> Please avoid comments like
>> //begin fix for ixxxxxx
>> ...
>> //end of fix
>>
>> Such comments are useless and if someone does care that type of
>> information is registered by the version control system (SVN) anyways.
>>
>> Pedro.
>>
>
>
>
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability
with MS Word Binary Format
Posted by chengjh <ch...@apache.org>.
The comment format can provide another way to get the whole code change
set,except svn, which is valuable for someone who has only the code base,is
not familiar with the tool svn, especially,meets regression issue related
to the code change.The comments will be quite helpful.
On Tue, Oct 9, 2012 at 12:04 PM, Pedro Giffuni <pf...@apache.org> wrote:
> Hello;
>
> --- Lun 8/10/12, chengjh ha scritto:
>
>
> > Data: Lunedì 8 ottobre 2012, 20:21
> > I have delivered the patch
> > https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff
> > to
> > improve the graphic bullet interoperability with MS Word
> > binary document.
> > Can any expert help the code review before I commit
> > it?Thanks in advance.
> >
> > [1]Call for Test::http://s.apache.org/YYk
> >
>
>
> Please avoid comments like
> //begin fix for ixxxxxx
> ...
> //end of fix
>
> Such comments are useless and if someone does care that type of
> information is registered by the version control system (SVN) anyways.
>
> Pedro.
>
--
Best Regards,Jianhong Cheng
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format
Posted by Pedro Giffuni <pf...@apache.org>.
Hello;
--- Lun 8/10/12, chengjh ha scritto:
> Data: Lunedì 8 ottobre 2012, 20:21
> I have delivered the patch
> https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff
> to
> improve the graphic bullet interoperability with MS Word
> binary document.
> Can any expert help the code review before I commit
> it?Thanks in advance.
>
> [1]Call for Test::http://s.apache.org/YYk
>
Please avoid comments like
//begin fix for ixxxxxx
...
//end of fix
Such comments are useless and if someone does care that type of information is registered by the version control system (SVN) anyways.
Pedro.
Re: [Proposal]Propose to Improve the Graphic Bullets Interoperability with MS Word Binary Format
Posted by Pedro Giffuni <pf...@apache.org>.
Hello;
--- Lun 8/10/12, chengjh ha scritto:
> Data: Lunedì 8 ottobre 2012, 20:21
> I have delivered the patch
> https://issues.apache.org/ooo/attachment.cgi?id=79748&action=diff
> to
> improve the graphic bullet interoperability with MS Word
> binary document.
> Can any expert help the code review before I commit
> it?Thanks in advance.
>
> [1]Call for Test::http://s.apache.org/YYk
>
Please avoid comments like
//begin fix for ixxxxxx
...
//end of fix
Such comments are useless and if someone does care that type of information is registered by the version control system (SVN) anyways.
Pedro.