You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/06 16:29:50 UTC

[GitHub] [tvm] Lunderberg commented on pull request #11973: [TIR] Moved PrimExpr operator overload from op.h to expr.h

Lunderberg commented on PR #11973:
URL: https://github.com/apache/tvm/pull/11973#issuecomment-1176431819

   And rebased onto #12010, and that clears up almost everything.  I have a few additional commits on this PR, in order to resolve the last of the ambiguous operators.
   
   The [change for `BufferInfoExtractor::call_order_`](https://github.com/apache/tvm/pull/11973/commits/4eca8e0fd10228805ac4421585475248c54b0f15) avoided the implicit use of `ObjectRef::operator<`, but did require more than just a syntax change.  @manupa-arm , could you take a glance at it and make sure that this change follows your intention?  Based on the docstring for `BufferInfoExtract::call_order_`, it looks like this `std::set` was intended to contain `Call` objects in order of occurrence and the use of `ObjectRef::operator<` was unintentional, but I'd like to verify.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org