You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "ayusheshan (via GitHub)" <gi...@apache.org> on 2023/10/13 08:42:59 UTC
[PR] added test for ClusterStatusSubscriberTest [shardingsphere]
ayusheshan opened a new pull request, #28749:
URL: https://github.com/apache/shardingsphere/pull/28749
Fixes #28488
Changes proposed in this pull request:
-added test for ClusterStatusSubscriberTest
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added test for ClusterStatusSubscriberTest [shardingsphere]
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on PR #28749:
URL: https://github.com/apache/shardingsphere/pull/28749#issuecomment-1761320409
Please fix ci, you need to check ci in your local environment，you can refer to : https://shardingsphere.apache.org/community/en/involved/conduct/code/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added test for ClusterStatusSubscriberTest [shardingsphere]
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 merged PR #28749:
URL: https://github.com/apache/shardingsphere/pull/28749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added test for ClusterStatusSubscriberTest [shardingsphere]
Posted by "ayusheshan (via GitHub)" <gi...@apache.org>.
ayusheshan commented on PR #28749:
URL: https://github.com/apache/shardingsphere/pull/28749#issuecomment-1761575350
apologies for that. I have fixed it now and build is succeeding in my local now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org