[GitHub] rhtyd commented on a change in pull request #2177: Enhance SSL protocol used by Console Proxy

[gi...@git.apache.org]

rhtyd commented on a change in pull request #2177: Enhance SSL protocol used by Console Proxy
URL: https://github.com/apache/cloudstack/pull/2177#discussion_r127178874
 
 

 ##########
 File path: services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java
 ##########
 @@ -38,6 +38,11 @@
     private static final Logger s_logger = Logger.getLogger(ConsoleProxySecureServerFactoryImpl.class);
 
     private SSLContext sslContext = null;
+    private static String[] SSL_PROTOCOLS = { "TLSv1", "TLSv1.1", "TLSv1.2" };
+    private static String[] SSL_CIPHERS = { "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA", "TLS_DHE_RSA_WITH_AES_128_GCM_SHA256", "TLS_DHE_RSA_WITH_AES_128_CBC_SHA256",
+            "TLS_RSA_WITH_AES_128_GCM_SHA256", "TLS_RSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
 
 Review comment:
   @GabrielBrascher do you think we can get the list of ciphers moved/refactored to SSLUtils and other parts of the system may use it (now or in future?)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services